Skip to content
This repository has been archived by the owner on Mar 18, 2023. It is now read-only.

3.0.1 and 3.0.2 broke being able to find svg asset #99

Open
roastlechon opened this issue Aug 1, 2016 · 9 comments
Open

3.0.1 and 3.0.2 broke being able to find svg asset #99

roastlechon opened this issue Aug 1, 2016 · 9 comments
Assignees
Labels
Milestone

Comments

@roastlechon
Copy link

usage code:

import svgxhr from 'webpack-svgstore-plugin/src/helpers/svgxhr';
import React, { PropTypes } from 'react';

const __svg__ = {
  path: './svg/**/*.svg',
  name: '/images/svg/[hash].icon.svg'
};

svgxhr(__svg__);

Network panel on dev tools and server shows:

/images/svg/[hash].icon.svg 500 14.228 ms - -
@mrsum
Copy link
Owner

mrsum commented Aug 2, 2016

Hi @roastlechon thx for issue.
I'll see your report right now.

@mrsum mrsum added the bug label Aug 2, 2016
@mrsum mrsum self-assigned this Aug 2, 2016
@mrsum
Copy link
Owner

mrsum commented Aug 2, 2016

@roastlechon could you fix on 3.0.0 version, i'll let you know when bug will fixed.

@matpaul
Copy link
Contributor

matpaul commented Aug 2, 2016

@mrsum Sorry it's my fail, i check previous commit (Long term caching) in build time and it's work, but in webpack dev server i have same issue as above.

@mrsum
Copy link
Owner

mrsum commented Aug 2, 2016

@matpaul Don't worry about it ) I'll fix ASAP

@matpaul
Copy link
Contributor

matpaul commented Aug 2, 2016

@mrsum Big Thx!

@mrsum
Copy link
Owner

mrsum commented Aug 2, 2016

@roastlechon @matpaul Guys, i've spent all day and best decision what i took is revert to version without caching support.

I've bring back 3.0.0 version as 3.0.3 cause i cant unpublish them.
So, i'll back soon for resolving #98

@roastlechon
Copy link
Author

Thanks for the quick reply/discussion @matpaul @mrsum. I fixed on 3.0.0 in my package.json.

@mrsum mrsum added this to the 3.0.4 milestone Aug 3, 2016
@matpaul
Copy link
Contributor

matpaul commented Aug 12, 2016

@mrsum any updates ?)

@mrsum
Copy link
Owner

mrsum commented Aug 23, 2016

@matpaul I finished for long-term caching support
https://github.com/mrsum/webpack-svgstore-plugin/blob/feature/long-term-caching/src/svgstore.js

after testing, will publish new release in next few days

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants