Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iridium-parser requires --stats #122

Closed
rpatel3001 opened this issue Nov 30, 2024 · 2 comments
Closed

iridium-parser requires --stats #122

rpatel3001 opened this issue Nov 30, 2024 · 2 comments

Comments

@rpatel3001
Copy link
Contributor

without --stats, the stats dict is not created. There are unguarded accesses to the stats dict that throw exceptions. either the stats dict creation should be unconditional or all the stats dict accesses should be made conditional on args.do_stats.

Sec42 added a commit that referenced this issue Dec 2, 2024
@Sec42
Copy link
Member

Sec42 commented Dec 2, 2024

Can you provide me with an example commandline where this happens for you? All the normal use-cases work for me.

Reading the code, I realize it can break it with "-o zmq" if not running on a tty -- that's because the zmq mode is intended to be used with stats, but I guess I can silence the output there.

I've pushed a fix on the testing branch. Let me know if that was your problem.

@rpatel3001
Copy link
Contributor Author

It's in a docker container, though I do have tty: true set. Regardless, the testing branch does fix it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants