-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Datepicker rendered without the button in test environment #10876
Comments
Hello @mor-stampli P.S. We had the same issue on our end and have specified the necessary flag to avoid this problem. Line 94 in 4295a7f
|
@LukasTy thanks |
Hi @LukasTy , could you please check if there is anything else we need in order to make it work ? here you can see the code we have running -> |
@mor-stampli In the microsoft/playwright#7769 (comment) I've mentioned that this setting needs to be passed via a |
@dgodongm Why do you consider it an issue? |
@LukasTy Isn't it an issue that the DatePicker shows the mobile experience on a desktop environment? The workaround is also very non-intuitive and hard to discover. While the scenario might be unlikely to directly impact end-users, it's a common scenario for test automation. |
I'm not saying it is ideal, but the current default value of the prop controlling the toggle feels versatile, albeit slightly problematic. 🤔 @dgodongm Given that we have #10039, could you explore the suggested updated media query ( |
@LukasTy I was able to workaround issue via the Chrome pointer setting (specifically using the Cypress config setting advised here). I'd still argue that MUI's DatePicker is effectively a black box and the MUI documentation specifies certain behavior for mobile vs desktop. If there are limitations/quirks in certain cases, it'd be great if these could be documented along with possible workarounds (rather than living only in git issues). Thx for the help. |
@dgodongm Were you able to discover this section in the docs? 🤔 |
@LukasTy This is great! Somehow I missed that in reviewing the DatePicker docs and it didn't come up when searching for solutions. The latter is probably my not choosing the right search terms. Perhaps the help doc could mention the symptoms of the headless browser scenario? Thx |
@dgodongm Thank you for your suggestion. 👍 P.S. I've tested the updated media query on headless chrome to confirm that it wouldn't change anything. 😉 |
Duplicates
Steps to reproduce 🕹
Link to live example:
Steps:
Current behavior 😯
I am running an app that uses MUI version 5
@mui/x-data-grid-pro: 5.7.0
i have very weird behavior.
first instance works great as expected.
for some reason,
DatePicker on the second instance instance is rendered with a different JSX.
picker calendar button is not rendered at all.
is there any special case for this environment ?
am i missing something?
Screen.Recording.2023-11-02.at.1.27.03.PM.mov
Expected behavior 🤔
i expect the DatePicker to rendered with the calendar picker icon button in all environments.
Context 🔦
No response
Your environment 🌎
npx @mui/envinfo
Search keywords:
The text was updated successfully, but these errors were encountered: