[DataGrid] Make checkboxSelection respect the disableMultipleRowSelection prop
#11448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
component: data grid
|
Deploy preview: https://deploy-preview-11448--material-ui-x.netlify.app/ Updated pages: |
cherniavskii
commented
Dec 20, 2023
Comment on lines
+10
to
+15
| if (props.signature === GridSignature.DataGrid) { | ||
| // DataGrid Community has multiple row selection enabled only if checkbox selection is enabled. | ||
| return props.checkboxSelection && props.disableMultipleRowSelection !== true; | ||
| } | ||
| return !props.disableMultipleRowSelection; | ||
| } |
There was a problem hiding this comment.
This is a bit messy, but the main change in this PR is that you can now pass the disableMultipleRowSelection prop to MIT DataGrid.
The default behavior hasn't changed, so this PR does not bring any breaking changes.
cherniavskii
added
customization: logic
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
MBilalShafi
approved these changes
Dec 22, 2023
|
Does it work with Data-Grid-Pro for u guys? |
|
@Ciframa Sure, here's a demo: https://stackblitz.com/edit/react-bvyzcm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5286
Preview: https://deploy-preview-11448--material-ui-x.netlify.app/x/react-data-grid/row-selection/#checkbox-selection