Mark lots of enums #[non_exhaustive]
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
src/service.rs line 950 at r1 (raw file):
/// Enum describing the reason of a SessionChange event #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] #[non_exhaustive]
This seems to be exhaustive right now.
faern
force-pushed
the
mark-enums-non_exhaustive
branch
from
37df250 to
f215e4a
Compare
faern
commented
Apr 16, 2024
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @dlon)
src/service.rs line 950 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
This seems to be exhaustive right now.
Ok! Yes, seems you are right. I removed that commit.
dlon
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
faern
changed the title
#[non exhaustive]#[non_exhaustive]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the upcoming
0.7.0release we have a lot of breaking changes due to adding variants to enums. Lots of these enums are probably still not exhaustive. To mitigate having to make breaking changes for small stuff in the future, I mark them as#[non_exhaustive]. If you think any of these actually are fully exhaustive now, and/or if you think an addition to one of them actually should be a breaking change, then please give that as feedback.I want this merged before the
0.7.0release.This change is