Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration/systems tests #63

Open
gbp opened this issue Apr 27, 2018 · 1 comment
Open

Add integration/systems tests #63

gbp opened this issue Apr 27, 2018 · 1 comment

Comments

@gbp
Copy link
Member

gbp commented Apr 27, 2018

While rebasing commits for #60 I inadvertently broke some commits but the test suite stayed green. This shows an issue with our test suite which stems from a new convention in Rails to prefer integration/system tests over controller tests.

We could include the rails-controller-testing gem to do things the old way but as we are trying to do things the right/modern way for this project it makes sense to add a few systems test for the FOI workflow.

@garethrees
Copy link
Member

Noting #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants