Skip to content

Latest commit

 

History

History
130 lines (105 loc) · 5.2 KB

CONTRIBUTING.md

File metadata and controls

130 lines (105 loc) · 5.2 KB
Raw

Contributing to Distrobox

We greatly appreciate your input! We want to make contributing to this project as easy and transparent as possible, whether it's:

  • Reporting a bug
  • Discussing the current state of the code
  • Submitting a fix
  • Proposing new features

Creating a Pull Requests

Pull requests are the best way to propose changes to the codebase.
We actively welcome your pull requests:

  1. Fork the repo and create your branch from main.
  2. If you've added code that should be tested, add tests.
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes.
  5. Make sure your code lints.
  6. Issue that pull request!

Any contributions you make will be under the GPLv3 Software License

In short, when you submit code changes, your submissions are understood to be under the same GPLv3 License that covers the project. Feel free to contact the maintainers if that's a concern.

Suggestions

Suggestions are welcome, be sure:

  • It is not already being discussed in the issue tracker
    • If it has and is marked as OPEN, go ahead and share your own thoughts about the topic!
    • If it has and is marked as CLOSED, please read the ticket and depending on whether the suggestion was accepted consider if it is worth opening a new issue or not.
  • Consider if the suggestion is not too out of scope of the project.
  • Mark them with a [Suggestion] in the title.

Report bugs using GitHub's issues

We use GitHub issues to track public bugs. Report a bug by opening a new issue; it's that easy!

Write bug reports with detail, background, and sample code

A good bug report should have:

  • Check that the bug is not already discussed in the issue tracker
  • See our documentation if there are some steps that could help you solve your issue
  • Mark them with an [Error] in the title
  • A quick summary and/or background
  • Steps to reproduce
    • Be specific!
    • Provide logs (terminal output, runs with verbose mode)
  • What you expected would happen
  • What actually happens
  • Notes (possibly including why you think this might be happening, or stuff you tried that didn't work)

Use a Consistent Coding Style

  • check if files have some problems with POSIX using the following:
for file in $(find . -type f -not -path "*.git*"); do
    if file "$file" | grep -qi shell; then
      echo "### Checking file $file..."
      dash -n $file
      result=$(( result + $? ))
    fi
done

Here we're using dash to verify if there are any non-POSIX code inside the scripts. Distrobox aims to be POSIX compliant so it's important to use a strict POSIX compliant shell to verify. dash is available in all major distributions' repositories.

  • use shellcheck to check for posix compliance and bashisms using:
    • install from: HERE following this
    • shellcheck -s sh -a -o all -Sstyle -Calways -x -e SC2310,SC2311,SC2312
  • use shfmt to style the code using:
    • install from HERE using go install mvdan.cc/sh/v3/cmd/shfmt@latest
    • shfmt -d -s -ci -sr -kp
  • use bashate to check the code:
    • install using pip3 install bashate
    • bashate -i E002,E003,E010,E011 --max-line-length 12
  • use markdownlint
    • install using npm -i -g markdownlint-cli
    • run markdownlint $(find . -name '*.md' | grep -vF './.git')
  • Legibility of the code is more important than code golfing, try to be expressive in the code
  • Try to follow the happy path:
    • This guide is for golang, but it's a very insightful source to follow
  • Error checking is important! Ensure to LBYL (Look Before You Leap), check for variables and for code success exit codes
  • If a command or function can fail, ensure you check the outcome:
    • if ! my_function; then ... this is important to handle errors gracefully and to potentially warn users of what's happening
  • Use snake_case for variable naming. Keep variable names lowercase if they are not an environment variable
  • Don't hesitate to comment your code! We're placing high importance on this to maintain the code readable and understandeable
  • Update documentation to reflect your changes - Manual pages can be found in directory docs

If you are using Visual Studio Code, there are plugins that include all this functionality and throw a warning if you're doing something wrong. If you are using Vim or Emacs there are plenty of linters and checkers that will integrate with the 2 tools listed above.

License

By contributing, you agree that your contributions will be licensed under its GPLv3 License.

References

This document was adapted from the open-source contribution guidelines for Facebook's Draft.