Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'receivable' rpc – rename "threshold" to "amount_minimum", add "amount_exact" #4810

Open
keerifox opened this issue Dec 22, 2024 · 0 comments

Comments

@keerifox
Copy link

Summary

receivable rpc could have threshold renamed to amount_minimum, and have a new option amount_exact

What problem would be solved by this feature?

when expecting a payment of exactly Ӿ0.123456, polling receivable with a threshold of Ӿ0.123456 would also show transactions with amounts Ӿ3.5, Ӿ4.75, Ӿ80 etc.

  • this adds a little extra complexity to the implementation needing to filter out greater amounts
  • if the output is limited to say 20 entries, the transaction of interest would be missing from the output not when there are 20 transactions of exactly Ӿ0.123456, but when there are 20 transactions greater or equal to that amount

Are there any previous requests for this feature?

haven't seen one

Do you have a suggested solution?

alternatively there could be a new rpc that would return block hashes from both receivable and account_history that match the specified amount, ensuring that if the user requests a limit of 25, those 25 transactions are the most recent by timestamp

in the past there has been a service implementing this functionality in its middleware layer, meaning it needed to call multiple rpc's

If this feature is approved, would you be willing to submit a pull request with the solution?

I would not

Possible solution

No response

Supporting files

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant