From 45ba2f4bae3ce710edd10282a3113ad26062eac4 Mon Sep 17 00:00:00 2001
From: Josie Lyon <82548520+lyonthefrog@users.noreply.github.com>
Date: Fri, 11 Oct 2024 17:50:06 -0500
Subject: [PATCH] Update reference files for DAS-2205 bug fix (#103)

* Update reference files for DAS-2205 bug fix, add try/except to compare function to all tests to run.

* Update CHANGELOG.md.

* Run pre-commit and remove trailing whitespace.

* DAS-2205 - Move try/except to tests, print test result report, and throw an error if a test fails.

* DAS-2205 - Update nsidc-icesat2 image version.

* Remove empty cell.

* Remove full run of notebook with fails for efficiency.

* Re-add accidentally removed print_success.

* Correct typo.

* Correct typo.
---
 CHANGELOG.md                                           | 10 +++++++++-
 test/nsidc-icesat2/NSIDC-ICESAT2_Regression.ipynb      |  2 +-
 .../ATL03_subset_bounding_box_reference.h5             |  4 ++--
 .../ATL08_subset_bounding_box_reference.h5             |  4 ++--
 .../ATL08_subset_by_shapefile_reference.h5             |  4 ++--
 test/nsidc-icesat2/version.txt                         |  2 +-
 6 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5b7c140e..8bdc2857 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,13 +5,21 @@ versioning. Rather than a static releases, this repository contains of a number
 of regression tests that are each semi-independent.  This CHANGELOG file should be used
 to document pull requests to this repository.
 
+## 2024-10-11 ([#103](https://github.com/nasa/harmony-regression-tests/pull/103))
+
+- Update the ATL03 and ATL08 reference files in the `nsidc-icesat2` regression
+  test notebook to adjust to the DAS-2205 bug fix.
+- Updates the `shared_utils` function `compare_results_to_reference_file_new`
+  to surround comparison assertion with a `try`/`except` so all tests are run
+  even when a comparison fails.
+
 ## 2024-10-02 ([#99](https://github.com/nasa/harmony-regression-tests/pull/99))
 
 - Adds NSIDC ICESat2 Production Regression configuration.
 - Updates the `shared_utils` function `compare_results_to_reference_file_new`
   to take a new optional argument `identical` which defaults to `True` but if
   set to `False` the Datatree comparison falls back to an `equals` test
-  ignoring metadata in its reference file comparions.
+  ignoring metadata in its reference file comparisons.
 
 
 ## 2024-09-24 ([#92](https://github.com/nasa/harmony-regression-tests/pull/92))
diff --git a/test/nsidc-icesat2/NSIDC-ICESAT2_Regression.ipynb b/test/nsidc-icesat2/NSIDC-ICESAT2_Regression.ipynb
index 1d56c216..72c2ec78 100644
--- a/test/nsidc-icesat2/NSIDC-ICESAT2_Regression.ipynb
+++ b/test/nsidc-icesat2/NSIDC-ICESAT2_Regression.ipynb
@@ -524,7 +524,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.11.5"
+   "version": "3.11.10"
   }
  },
  "nbformat": 4,
diff --git a/test/nsidc-icesat2/reference_files/ATL03_subset_bounding_box_reference.h5 b/test/nsidc-icesat2/reference_files/ATL03_subset_bounding_box_reference.h5
index 1a1b16e8..28a53f48 100644
--- a/test/nsidc-icesat2/reference_files/ATL03_subset_bounding_box_reference.h5
+++ b/test/nsidc-icesat2/reference_files/ATL03_subset_bounding_box_reference.h5
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:37f651389ece5b020090d5c24ff233d5e5e9cc930bae0549ac094f82ce29991a
-size 59773221
+oid sha256:e462641aa14136cc1057a526e5fac4f409a61335e2b7d25541967c8651a35d56
+size 59773333
diff --git a/test/nsidc-icesat2/reference_files/ATL08_subset_bounding_box_reference.h5 b/test/nsidc-icesat2/reference_files/ATL08_subset_bounding_box_reference.h5
index c503137e..35fae5eb 100644
--- a/test/nsidc-icesat2/reference_files/ATL08_subset_bounding_box_reference.h5
+++ b/test/nsidc-icesat2/reference_files/ATL08_subset_bounding_box_reference.h5
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:51f1cb5ae5b2273f56983aa55abad50fdd4a7f0a474f66cecba73a056065675e
-size 4549080
+oid sha256:943bff4a454df6f60f96c7f7d46450bb00cbf5da4434be9d45e5baa71ff02fa6
+size 4549119
diff --git a/test/nsidc-icesat2/reference_files/ATL08_subset_by_shapefile_reference.h5 b/test/nsidc-icesat2/reference_files/ATL08_subset_by_shapefile_reference.h5
index a7633390..f7c45282 100644
--- a/test/nsidc-icesat2/reference_files/ATL08_subset_by_shapefile_reference.h5
+++ b/test/nsidc-icesat2/reference_files/ATL08_subset_by_shapefile_reference.h5
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:154d5c6b89c9b157120d846b739a0a96f4f2ab372428f7f7254a77cbfb304d0d
-size 6123965
+oid sha256:1dd44f54e54add3684172a4a5cd555cda6ea533598b91972a5a41afbd1b6cdbc
+size 6123999
diff --git a/test/nsidc-icesat2/version.txt b/test/nsidc-icesat2/version.txt
index bcab45af..81340c7e 100644
--- a/test/nsidc-icesat2/version.txt
+++ b/test/nsidc-icesat2/version.txt
@@ -1 +1 @@
-0.0.3
+0.0.4