Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded organization name prevents github actions from running in a forked repository #117

Open
asjohnston-asf opened this issue Nov 19, 2024 · 0 comments

Comments

@asjohnston-asf
Copy link
Contributor

A couple places in the docker build/push/pull/run scripts assume the github organization is nasa in the GHCR url. That leads to "permission denied" errors when I try to build or run the tests from my asjohnston-asf fork.

  1. https://github.com/nasa/harmony-regression-tests/blob/main/.github/workflows/notebook-test-suite.yml#L135
  2. https://github.com/nasa/harmony-regression-tests/blob/main/script/image_name.sh#L18

The first can be easily generalized by using ${{github.repository_owner}}, but I don't see a trivial fix for the second.

I was able to work around this by editing the owner in a separate branch and running the test action from that branch via workflow dispatch (after building the container from my feature branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant