From a5477da9a23e2b804dbc000d69a0dbb1f58938b5 Mon Sep 17 00:00:00 2001 From: Nic Annau Date: Tue, 9 Jul 2024 00:25:59 +0000 Subject: [PATCH 1/2] fix: deprecation of xarray .dims --- ncompare/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ncompare/core.py b/ncompare/core.py index 113efa9..8b8d040 100644 --- a/ncompare/core.py +++ b/ncompare/core.py @@ -636,7 +636,7 @@ def _get_groups(nc_filepath: Union[str, Path]) -> list: def _get_dims(nc_filepath: Union[str, Path]) -> list: def __get_dim_list(decode_times=True): with xr.open_dataset(nc_filepath, decode_times=decode_times) as dataset: - return list(dataset.dims.items()) + return list(dataset.sizes.items()) try: dims_list = __get_dim_list() From 62bc7e3667b7e45f4f31463a6f1f591efd9d3a68 Mon Sep 17 00:00:00 2001 From: Nic Annau Date: Tue, 9 Jul 2024 00:50:56 +0000 Subject: [PATCH 2/2] docs: add updates to changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bc4cf3d..4db924a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [Unreleased] +### Changed +- [Issue #246](https://github.com/nasa/ncompare/issues/246): Changed xarray Dataset.dims reference to Dataset.sizes due to FutureWarning + ## [1.9.0] ### Added - [Issue #210](https://github.com/nasa/ncompare/issues/210): Add gif of usage to readme