Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot view cursor guides in Time Strip views don't work #7960

Open
7 tasks
charlesh88 opened this issue Dec 11, 2024 · 0 comments
Open
7 tasks

Plot view cursor guides in Time Strip views don't work #7960

charlesh88 opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Dec 11, 2024

Summary

Currently, the cursor guide button in embedded plot views in a Time Strip is available and clickable, but the guides are confined to an individual plot element and don't work at all. Guides do follow the cursor in Stacked Plot views.

Cursor guide button appears on hover
Screenshot 2024-12-11 at 3 24 09 PM

Cursor guides are shown but don't follow cursor
Screenshot 2024-12-11 at 3 24 44 PM

Expected vs Current Behavior

There are a number of acceptable ways to fix this:

  1. BEST: Implement a cross-all-swimlanes cursor guide solution. Similar to how Stacked Plots work now, invoking cursor guides in one nested plot view enables them in all, but this enhancement makes the guide extents visible in all plot views at once, with data point hovering occurring in all plot views.

** Spanning cursor guides in a Stacked Plot view**
image

This however, is complicated in a Time Strip view, which allows Stacked Plots to be embedded as a child element, in effect allowing a stacked item within a stacked view. The cursor guides would have to allow for this situation and function across all stackable contained objects. Additionally, independently zoomed or panned plot views would have to be accounted for, ideally by properly calculating the guide position in relation to a a view's zoom or pan settings. If we go this route, a separate issue should be filed for this and it must be implemented in Stacked Plots as well.
2. GOOD: At least make them work the same as they do in Stacked Plots, with the guides enabled for all contained plot views, but only displayed within each at a time.
3. ARGH: Suppress the cursor guide button for plot views in a Time Strip. We should only do this if #2 is out of scope.

Steps to Reproduce

  1. Add plottable views to a Time Strip.
  2. Click a plot view's cursor guide button.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

charlesh88 added a commit that referenced this issue Dec 14, 2024
- Removed in-page `style` defs from ExtendedLinesOverlay.vue; CSS actually located in timeline.scss.
- Improved sizing and style for Marcus Bains ("now") line.
- Removed extraneous padding at bottom of plot view when in Time Strip.
- Added missing header info to timeline.scss.
- CSS refinements.
charlesh88 added a commit that referenced this issue Dec 14, 2024
- Removed bad `}` in TimeSystemAxis.vue.
- Removed `.u-contents` from line 129 of ganttChart.e2e.spec.js.
- Removed `event-handle` element; not needed.
- Changed `__event-wrapper` to not set height explicitly; uses absolute positioning.
- Added :before element to event-wrapper for better hit area.
- Improved hover styling.
- $colorEvent* style constants added to theme constant SCSS files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants