Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux notifier overwrites user's tmux confg #14

Open
firx opened this issue Sep 21, 2023 · 0 comments
Open

tmux notifier overwrites user's tmux confg #14

firx opened this issue Sep 21, 2023 · 0 comments

Comments

@firx
Copy link

firx commented Sep 21, 2023

To perform a notification, TmuxNotifier manually alters the user's tmux configuration value "window-status-style" with a fixed value of red or green. This is not raising an alert of any kind, it is manually changing the user's configuration. It causes several issues:

  • Most obviously, if the user's config already uses red or green in their status bar, the notification is either not visible or incorrect.
  • There is no way for the user to clear the notification other than killing the window or manually reconfiguring the value. (Tmux alerts are by default cleared by activating the window.)
  • It's surprising to developers, because tmux already has several configurable notification mechanisms.
  • It doesn't work with other terminal handlers, e.g. GNUscreen
  • It doesn't work over SSH or other environments where TMUX_PANE isn't propagated.

The tmux notifier doesn't seem necessary at all. ExUnit already provides an exit code for success or failure, and it is trivial to cause a terminal bell for failure (e.g. mix test || echo -e \\a) which is already handled as a notification by tmux and other systems.

Simply removing the tmux notifier fixes all the above issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant