Reviewers per groups

[mancarv]

Hi, if we hace the option number_of_reviewers: 2 and two groups, can it be configured to choose one reviewer per group?

[necojackarc]

Hi, @mancarv. That's a good question. I needed to browse the codebase to answer 😄

The logic to pick reviewers randamly to the number specified in number_of_reviewers is here:

auto-request-review/src/reviewer.js

Lines 114 to 124 in e08cdff

	function randomly_pick_reviewers({ reviewers, config }) {
	const { number_of_reviewers } = {
	...config.options,
	};
	if (number_of_reviewers === undefined) {
	return reviewers;
	}
	return sample_size(reviewers, number_of_reviewers);
	}

And this is called at the end of the logic:

auto-request-review/src/index.js

Line 65 in e08cdff

reviewers = randomly_pick_reviewers({ reviewers, config });

That means, at this moment, it's not possible to configure the number of reviewers for each group.

To implement this, we'd probably need to add another option (number_of_reviewrs_per_group, for instance).