Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all introduced in 5.x mentions from the dev branch #2022

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

renetapopova
Copy link
Contributor

No description provided.

@@ -3107,11 +3107,11 @@ m|+++false+++
|===


[role=label--new-5.7 label--dynamic-5.10 label--enterprise-edition]
[role=label--dynamic label--enterprise-edition]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[role=label--dynamic label--enterprise-edition]
[role=label--dynamic-5.10 label--enterprise-edition]

Copy link
Contributor Author

@renetapopova renetapopova Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this. In 2025, it is dynamic.

modules/ROOT/pages/procedures.adoc Outdated Show resolved Hide resolved
@@ -249,7 +249,7 @@ For more information, see the link:{neo4j-docs-base-uri}/cdc/{page-version}/[CDC
| *Mode* 3+| READ
|===

[role=label--new-5.17 label--beta]
[role=label--beta]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this label here? The CDC feature is GA starting from 5.23.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is GA, no.

@@ -263,7 +263,7 @@ For more information, see the link:{neo4j-docs-base-uri}/cdc/{page-version}/[CDC
| *Mode* 3+| READ
|===

[role=label--enterprise-edition label--new-5.17 label--beta label--admin-only]
[role=label--enterprise-edition label--beta label--admin-only]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[role=label--enterprise-edition label--beta label--admin-only]
[role=label--enterprise-edition label--beta label--GA-5.23 label--admin-only]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or to remove the beta label and not to use the GA label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should remove all mentions of 5.x, including GAs, etc. If the feature is no longer beta, we should also remove beta labels.

@NataliaIvakina
Copy link
Contributor

NataliaIvakina commented Dec 23, 2024

One general question: there is the PR to remove all mentions of the discover service v1. Do we need to remove labels from settings, procedures, etc. here if they will be completely removed in the aforementioned PR?

@@ -235,7 +235,7 @@ For more information, see the link:{neo4j-docs-base-uri}/cdc/{page-version}/[CDC
| *Replaced by* 3+| xref:procedures.adoc#db_cdc_query[`db.cdc.query()`]
|===

[role=label--enterprise-edition label--beta]
[role=label--enterprise-edition label--beta label--GA-5.23]
Copy link
Contributor Author

@renetapopova renetapopova Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it should be just:

[role=label--enterprise-edition]

@renetapopova
Copy link
Contributor Author

One general question: there is the PR to remove all mentions of the discover service v1. Do we need to remove labels from settings, procedures, etc. here if they will be completely removed in the aforementioned PR?

Hmm, that's a good question. There will be conflicts between those two PRs for sure. Probably, it doesn't really matter if we fix them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants