-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all introduced in 5.x mentions from the dev branch #2022
base: dev
Are you sure you want to change the base?
Remove all introduced in 5.x mentions from the dev branch #2022
Conversation
modules/ROOT/pages/authentication-authorization/manage-users.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/ldap-integration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-users.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-users.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-users.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-users.adoc
Outdated
Show resolved
Hide resolved
@@ -3107,11 +3107,11 @@ m|+++false+++ | |||
|=== | |||
|
|||
|
|||
[role=label--new-5.7 label--dynamic-5.10 label--enterprise-edition] | |||
[role=label--dynamic label--enterprise-edition] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[role=label--dynamic label--enterprise-edition] | |
[role=label--dynamic-5.10 label--enterprise-edition] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. In 2025, it is dynamic.
modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/procedures.adoc
Outdated
@@ -249,7 +249,7 @@ For more information, see the link:{neo4j-docs-base-uri}/cdc/{page-version}/[CDC | |||
| *Mode* 3+| READ | |||
|=== | |||
|
|||
[role=label--new-5.17 label--beta] | |||
[role=label--beta] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this label here? The CDC feature is GA starting from 5.23.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is GA, no.
modules/ROOT/pages/procedures.adoc
Outdated
@@ -263,7 +263,7 @@ For more information, see the link:{neo4j-docs-base-uri}/cdc/{page-version}/[CDC | |||
| *Mode* 3+| READ | |||
|=== | |||
|
|||
[role=label--enterprise-edition label--new-5.17 label--beta label--admin-only] | |||
[role=label--enterprise-edition label--beta label--admin-only] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[role=label--enterprise-edition label--beta label--admin-only] | |
[role=label--enterprise-edition label--beta label--GA-5.23 label--admin-only] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or to remove the beta
label and not to use the GA
label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should remove all mentions of 5.x, including GAs, etc. If the feature is no longer beta, we should also remove beta labels.
One general question: there is the PR to remove all mentions of the discover service v1. Do we need to remove labels from settings, procedures, etc. here if they will be completely removed in the aforementioned PR? |
…on.adoc Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
…/delete-composite-databases.adoc Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
modules/ROOT/pages/procedures.adoc
Outdated
@@ -235,7 +235,7 @@ For more information, see the link:{neo4j-docs-base-uri}/cdc/{page-version}/[CDC | |||
| *Replaced by* 3+| xref:procedures.adoc#db_cdc_query[`db.cdc.query()`] | |||
|=== | |||
|
|||
[role=label--enterprise-edition label--beta] | |||
[role=label--enterprise-edition label--beta label--GA-5.23] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think it should be just:
[role=label--enterprise-edition]
Co-authored-by: NataliaIvakina <[email protected]>
Co-authored-by: NataliaIvakina <[email protected]>
Hmm, that's a good question. There will be conflicts between those two PRs for sure. Probably, it doesn't really matter if we fix them now. |
This PR includes documentation updates Updated pages: |
No description provided.