Startup Experiments #232

shartte · 2024-12-25T00:31:55Z

No description provided.

Fix tests Move mixin loading to after TCL construction Fixes Fixin Mixin Working on tests Startup Experiments

neoforged-pr-publishing · 2024-12-25T00:32:09Z

Publish PR to GitHub Packages

Last commit published: 3c7878d0703b102e6be7c324da034a88682ee51e.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #232' // https://github.com/neoforged/FancyModLoader/pull/232
        url 'https://prmaven.neoforged.net/FancyModLoader/pr232'
        content {
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'tests')
        }
    }
}

neoforged-compatibility-checks · 2024-12-25T01:11:08Z

@shartte, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 3c7878d0703b102e6be7c324da034a88682ee51e.

Compatibility checks

`loader (:loader)`

net/neoforged/fml/loading/log4j/ForgeHighlight
- ❗ API class no longer exists
net/neoforged/fml/loading/ClasspathTransformerDiscoverer
- ❗ API class no longer exists
net/neoforged/fml/loading/mixin/FMLMixinContainerHandle
- ❗ API class no longer exists
cpw/mods/modlauncher/serviceapi/ITransformerDiscoveryService
- ❗ API class no longer exists
net/neoforged/fml/loading/targets/NeoForgeDevLaunchHandler
- ❗ Class missing interface: cpw/mods/modlauncher/api/ILaunchHandlerService
cpw/mods/modlauncher/TransformerClassWriter
- createClassWriter(ILcpw/mods/modlauncher/ClassTransformer;Lorg/objectweb/asm/tree/ClassNode;)Lorg/objectweb/asm/ClassWriter;: ❗ API method was removed
cpw/mods/modlauncher/api/TargetType
- get(Ljava/util/Map;)Lcpw/mods/modlauncher/TransformList;: ❗ API method was removed
- mapSupplier(Ljava/util/Map;)Ljava/util/function/Supplier;: ❗ API method was removed
net/neoforged/fml/loading/moddiscovery/ModDiscoverer
- discoverMods()Lnet/neoforged/fml/loading/moddiscovery/ModValidator;: ❗ API method was removed
cpw/mods/modlauncher/ArgumentHandler
- ❗ API class no longer exists
net/neoforged/fml/loading/targets/NeoForgeClientDevLaunchHandler
- ❗ API class no longer exists
net/neoforged/fml/loading/targets/JUnitDevLaunchTarget
- ❗ API class no longer exists
cpw/mods/modlauncher/api/ITransformerActivity
- context()[Ljava/lang/String;: ❗ Method was made abstract
- getContext()[Ljava/lang/String;: ❗ API method was removed
- type()Lcpw/mods/modlauncher/api/ITransformerActivity$Type;: ❗ Method was made abstract
- getType()Lcpw/mods/modlauncher/api/ITransformerActivity$Type;: ❗ API method was removed
cpw/mods/modlauncher/DefaultLaunchHandlerService
- ❗ API class no longer exists
net/neoforged/fml/loading/mixin/DeferredMixinConfigRegistration
- ❗ API class no longer exists
net/neoforged/fml/loading/targets/NeoForgeClientDataDevLaunchHandler
- ❗ API class no longer exists
cpw/mods/modlauncher/api/IEnvironment
- findLaunchHandler(Ljava/lang/String;)Ljava/util/Optional;: ❗ API method was removed
- findModuleLayerManager()Ljava/util/Optional;: ❗ API method was removed
- findLaunchPlugin(Ljava/lang/String;)Ljava/util/Optional;: ❗ API method was removed
net/neoforged/fml/loading/LoadingModList
- of(Ljava/util/List;Ljava/util/List;Ljava/util/List;Ljava/util/List;Ljava/util/Map;)Lnet/neoforged/fml/loading/LoadingModList;: ❗ API method was removed
- addForScanning(Lnet/neoforged/fml/loading/modscan/BackgroundScanHandler;)V: ❗ API method was removed
- addAccessTransformers()V: ❗ API method was removed
- addMixinConfigs()V: ❗ API method was removed
- addEnumExtenders()V: ❗ API method was removed
net/neoforged/neoforgespi/ILaunchContext
- modLists()Ljava/util/List;: ❗ API method was removed
- getJarSourceDescription(Ljava/nio/file/Path;)Ljava/lang/String;: ❗ Method was made abstract
- gameDirectory()Ljava/nio/file/Path;: ❗ Method was made abstract
- environment()Lcpw/mods/modlauncher/api/IEnvironment;: ❗ API method was removed
- relativizePath(Ljava/nio/file/Path;)Ljava/lang/String;: ❗ Method was made abstract
- setJarSourceDescription(Ljava/nio/file/Path;Ljava/lang/String;)V: ❗ Method was made abstract
- mods()Ljava/util/List;: ❗ API method was removed
- mavenRoots()Ljava/util/List;: ❗ API method was removed
- getUnclaimedClassPathEntries()Ljava/util/List;: ❗ Method was made abstract
- getRequiredDistribution()Lnet/neoforged/api/distmarker/Dist;: ❗ Method was made abstract
net/neoforged/fml/loading/targets/NeoForgeServerDataDevLaunchHandler
- ❗ API class no longer exists
cpw/mods/modlauncher/serviceapi/ILaunchPluginService
- offerResource(Ljava/nio/file/Path;Ljava/lang/String;)V: ❗ API method was removed
- getExtension()Ljava/lang/Object;: ❗ API method was removed
net/neoforged/fml/loading/ModDirTransformerDiscoverer
- ❗ API class no longer exists
net/neoforged/fml/loading/log4j/SLF4JFixerLaunchPluginService
- ❗ API class no longer exists
net/neoforged/fml/loading/moddiscovery/ModValidator
- ❗ API class no longer exists
cpw/mods/modlauncher/BootstrapLaunchConsumer
- ❗ API class no longer exists
net/neoforged/fml/loading/ImmediateWindowHandler$DummyProvider
- ❗ Class missing superclass of java/lang/Record
- hashCode()I: ❗ API method was removed
- equals(Ljava/lang/Object;)Z: ❗ API method was removed
- initialize([Ljava/lang/String;)Ljava/lang/Runnable;: ❗ API method was removed
- name()Ljava/lang/String;: ❗ API method was removed
- toString()Ljava/lang/String;: ❗ API method was removed
net/neoforged/fml/loading/targets/NeoForgeServerDevLaunchHandler
- ❗ API class no longer exists
net/neoforged/neoforgespi/earlywindow/ImmediateWindowProvider
- initialize([Ljava/lang/String;)Ljava/lang/Runnable;: ❗ API method was removed
- name()Ljava/lang/String;: ❗ API method was removed
net/neoforged/fml/loading/LauncherVersion
- ❗ API class no longer exists
net/neoforged/fml/util/DevEnvUtils
- ⚠ API class no longer exists
net/neoforged/neoforgespi/locating/IDiscoveryPipeline
- addLibrary(Ljava/nio/file/Path;)V: ❗ Method was made abstract
net/neoforged/fml/loading/targets/NeoForgeServerLaunchHandler
- ❗ Class missing interface: cpw/mods/modlauncher/api/ILaunchHandlerService
cpw/mods/modlauncher/TransformerHolder
- ❗ API class no longer exists
cpw/mods/modlauncher/util/ServiceLoaderUtils
- streamServiceLoader(Ljava/util/function/Supplier;Ljava/util/function/Consumer;)Ljava/util/stream/Stream;: ❗ API method was removed
- streamWithErrorHandling(Ljava/util/ServiceLoader;Ljava/util/function/Consumer;)Ljava/util/stream/Stream;: ❗ API method was removed
cpw/mods/modlauncher/LaunchPluginHandler
- <init>(Lcpw/mods/modlauncher/ModuleLayerHandler;)V: ❗ API method was removed
cpw/mods/modlauncher/TransformList
- ❗ API class no longer exists
cpw/mods/modlauncher/Launcher
- findLayerManager()Ljava/util/Optional;: ❗ API method was removed
- main([Ljava/lang/String;)V: ❗ API method was removed
cpw/mods/modlauncher/api/ILaunchHandlerService
- ❗ API class no longer exists
net/neoforged/fml/loading/moddiscovery/locators/MavenDirectoryLocator
- ❗ API class no longer exists
net/neoforged/fml/loading/TransformerDiscovererConstants
- ❗ API class no longer exists
cpw/mods/modlauncher/api/ITransformationService
- beginScanning(Lcpw/mods/modlauncher/api/IEnvironment;)Ljava/util/List;: ❗ API method was removed
- completeScan(Lcpw/mods/modlauncher/api/IModuleLayerManager;)Ljava/util/List;: ❗ API method was removed
cpw/mods/modlauncher/TransformerAuditTrail$TransformerActivity
- getContext()[Ljava/lang/String;: ❗ API method was removed
- getType()Lcpw/mods/modlauncher/api/ITransformerActivity$Type;: ❗ API method was removed
net/neoforged/fml/loading/targets/CommonLaunchHandler
- ❗ Class missing interface: cpw/mods/modlauncher/api/ILaunchHandlerService
- launchService([Ljava/lang/String;Ljava/lang/ModuleLayer;)Lcpw/mods/modlauncher/api/ServiceRunner;: ❗ API method was removed
- name()Ljava/lang/String;: ❗ Method was made abstract
cpw/mods/modlauncher/TransformerAuditTrail
- addTransformerAuditTrail(Ljava/lang/String;Lcpw/mods/modlauncher/api/ITransformationService;Lcpw/mods/modlauncher/api/ITransformer;)V: ❗ API method was removed
cpw/mods/modlauncher/TransformingClassLoader
- <init>(Lcpw/mods/modlauncher/TransformStore;Lcpw/mods/modlauncher/LaunchPluginHandler;Lcpw/mods/modlauncher/Environment;Ljava/lang/module/Configuration;Ljava/util/List;Ljava/lang/ClassLoader;)V: ❗ API method was removed
- <init>(Lcpw/mods/modlauncher/TransformStore;Lcpw/mods/modlauncher/LaunchPluginHandler;Lcpw/mods/modlauncher/Environment;Ljava/lang/module/Configuration;Ljava/util/List;)V: ❗ API method was removed
- <init>(Lcpw/mods/modlauncher/TransformStore;Lcpw/mods/modlauncher/LaunchPluginHandler;Lcpw/mods/modlauncher/api/IModuleLayerManager;)V: ❗ API method was removed
net/neoforged/fml/loading/ImmediateWindowHandler
- load(Ljava/lang/String;[Ljava/lang/String;)V: ❗ API method was removed
net/neoforged/fml/loading/FMLLoader
- ❗ Class was made final
- beginModScan(Lnet/neoforged/neoforgespi/ILaunchContext;)Ljava/util/List;: ❗ API method was removed
- beforeStart(Ljava/lang/ModuleLayer;)V: ❗ API method was removed
- completeScan(Lnet/neoforged/neoforgespi/ILaunchContext;Ljava/util/List;)Ljava/util/List;: ❗ API method was removed
net/neoforged/fml/loading/FMLServiceProvider
- ❗ API class no longer exists
net/neoforged/fml/loading/targets/NeoForgeClientLaunchHandler
- ❗ Class missing interface: cpw/mods/modlauncher/api/ILaunchHandlerService
net/neoforged/neoforgespi/Environment$Keys
- ❗ API class no longer exists
cpw/mods/modlauncher/TestingLaunchHandlerService
- ❗ API class no longer exists
cpw/mods/modlauncher/api/ITransformationService$Resource
- ❗ API class no longer exists
cpw/mods/modlauncher/Environment
- findLaunchHandler(Ljava/lang/String;)Ljava/util/Optional;: ❗ API method was removed
- findModuleLayerManager()Ljava/util/Optional;: ❗ API method was removed
- findLaunchPlugin(Ljava/lang/String;)Ljava/util/Optional;: ❗ API method was removed
cpw/mods/modlauncher/TransformationServiceDecorator
- ❗ API class no longer exists
net/neoforged/fml/loading/TracingPrintStream
- ❗ API class no longer exists
net/neoforged/fml/loading/mixin/FMLMixinPlatformAgent
- ❗ API class no longer exists
cpw/mods/modlauncher/TransformTargetLabel
- ❗ API class no longer exists
net/neoforged/neoforgespi/Environment
- build(Lcpw/mods/modlauncher/api/IEnvironment;)V: ❗ API method was removed

Dedicated server now starts.

Pass loader to JUnit service Fix self-attach issues. add control over dist cleaning to startup args.

shartte added 5 commits December 24, 2024 03:12

Work

c432c30

Fix tests Move mixin loading to after TCL construction Fixes Fixin Mixin Working on tests Startup Experiments

WIP

056c948

Removed PowerMock and adjusted ML tests

2643be7

Working on fixing all tests.

e11d4b7

Fix all tests

d823721

shartte changed the base branch from main to 7.x December 25, 2024 00:32

shartte added 2 commits December 25, 2024 01:36

Fix all tests

523209c

Fix all tests

060cd06

shartte added 20 commits December 25, 2024 02:22

Fix all tests

f7e5349

Run jmh in subproject.

7e8fadf

Reduce tested JVMs, add actual tests

1510853

Reduce tested JVMs, add actual tests

4d4a76f

Reduce tested JVMs, add actual tests

decfd1b

Reduce tested JVMs, add actual tests

01e0eb5

Reduce tested JVMs, add actual tests

cb1e1ec

Reduce tested JVMs, add actual tests

cdcd888

Reduce tested JVMs, add actual tests

0d9b3c6

Reduce tested JVMs, add actual tests

f59a8e1

Reduce tested JVMs, add actual tests

6ad3f33

8.12 breaks gradleutils in FML

fc78cee

Fix startup

11e475e

Fix startup (and self-attach)

ed12171

Remove unused startup code and consolidate it into loader project.

0fdfe41

Fixed annoying Gradle issues

9c2d583

Merged ctor with start for DisplayWindow

0ba407f

More cleanup. Reintroduced early service loading.

3e98dc7

Fixed test

4a9f1d9

Formatting

3c91e55

shartte added 18 commits December 29, 2024 11:17

Add datagen entrypoints.

0750e16

Formatting+Licenses

bd6839f

Rework how arguments are parsed

cd16a2b

Rework how production mode is detected

b55e2af

Refactoring FMLLoader and consolidating code.

bff9660

Dedicated server now starts.

Improve debug log for loaders

8657b28

Fixed tests

5bc8bf3

Fixed tests

42b0b7a

Remove local additions

cde4bda

Work on FML JUnit

3868a20

Work on FML JUnit

4b86992

Added JUnitGameBootstrapper to replace JUnitMain

fa932f4

Added JUnitGameBootstrapper to replace JUnitMain

3f774ed

Move to loader to make accessible to NeoForge

a609367

recursively delete game directory

3bd7fd9

recursively delete game directory

8bba47e

Normalize target class names

a0bb2e1

Add missing jar attributes to make FML jar work as javaagent

fb3ad8e

shartte mentioned this pull request Jan 2, 2025

Integration with FML Startup Experiments neoforged/NeoForge#1818

Draft

shartte added 4 commits January 3, 2025 15:29

Change how versions are embedded in FML

a16761a

Pass loader to JUnit service Fix self-attach issues. add control over dist cleaning to startup args.

Fix versioning test

489fee7

Fix versioning test

e484cf0

Fix publication

3c7878d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Startup Experiments #232

Startup Experiments #232

shartte commented Dec 25, 2024

neoforged-pr-publishing bot commented Dec 25, 2024 •

edited

Loading

The artifacts published by this PR:

Repository Declaration

neoforged-compatibility-checks bot commented Dec 25, 2024 •

edited

Loading

`loader (:loader)`

Startup Experiments #232

Are you sure you want to change the base?

Startup Experiments #232

Conversation

shartte commented Dec 25, 2024

neoforged-pr-publishing bot commented Dec 25, 2024 • edited Loading

The artifacts published by this PR:

Repository Declaration

neoforged-compatibility-checks bot commented Dec 25, 2024 • edited Loading

loader (:loader)

neoforged-pr-publishing bot commented Dec 25, 2024 •

edited

Loading

neoforged-compatibility-checks bot commented Dec 25, 2024 •

edited

Loading

`loader (:loader)`