-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy Support #36
Merged
Legacy Support #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shartte
commented
Jul 15, 2024
•
edited by Matyrobbrt
Loading
edited by Matyrobbrt
- NFRT needs the ability to supply a specific JDK home for recompilation and supplying the JRE libraries for Vineflower / Remapping. (It runs under 21 itself but the 1.20.1 decompiler crashes with J21 libs)
- Patches in 1.20.1 had a different prefix (not a/, b/), so I added the required support for specifying the patch prefix. 1.12 specified the different prefixes in its "userdev" config, so support for that is just added.
- Properly process the NeoForm/MCP java version in the recompile options (was harcoded to 21 before)
- NFRT gains support to remap the sources from SRG->Mojang via the Regular Expression based remapper
- Add a task that generates mappings in different formats and directions (named <-> intermediary, TSRG/SRG/CSV) for use in pre 1.20.1 toolchains
- Support for a few nitpicky changes in the Userdev JSON
Last commit published: b44e4762882eda6c9fdc4ce9e2a69ba53941b1d1. PR PublishingThe artifacts published by this PR:Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #36' // https://github.com/neoforged/NeoFormRuntime/pull/36
url 'https://prmaven.neoforged.net/NeoFormRuntime/pr36'
content {
includeModule('net.neoforged', 'neoform-runtime')
}
}
} |
Matyrobbrt
requested changes
Sep 5, 2024
src/main/java/net/neoforged/neoform/runtime/actions/RemapSrgSourcesAction.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoform/runtime/config/neoforge/NeoForgeConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoform/runtime/config/neoforge/NeoForgeConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoform/runtime/engine/ProcessGeneration.java
Outdated
Show resolved
Hide resolved
Matyrobbrt
reviewed
Sep 5, 2024
shartte
commented
Sep 8, 2024
src/main/java/net/neoforged/neoform/runtime/engine/NeoFormEngine.java
Outdated
Show resolved
Hide resolved
Matyrobbrt
approved these changes
Sep 8, 2024
🚀 This PR has been released as NeoFormRuntime version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.