Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy Support #36

Merged
merged 29 commits into from
Sep 8, 2024
Merged

Legacy Support #36

merged 29 commits into from
Sep 8, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jul 15, 2024

  • NFRT needs the ability to supply a specific JDK home for recompilation and supplying the JRE libraries for Vineflower / Remapping. (It runs under 21 itself but the 1.20.1 decompiler crashes with J21 libs)
  • Patches in 1.20.1 had a different prefix (not a/, b/), so I added the required support for specifying the patch prefix. 1.12 specified the different prefixes in its "userdev" config, so support for that is just added.
  • Properly process the NeoForm/MCP java version in the recompile options (was harcoded to 21 before)
  • NFRT gains support to remap the sources from SRG->Mojang via the Regular Expression based remapper
  • Add a task that generates mappings in different formats and directions (named <-> intermediary, TSRG/SRG/CSV) for use in pre 1.20.1 toolchains
  • Support for a few nitpicky changes in the Userdev JSON

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jul 15, 2024

  • Publish PR to GitHub Packages

Last commit published: b44e4762882eda6c9fdc4ce9e2a69ba53941b1d1.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #36' // https://github.com/neoforged/NeoFormRuntime/pull/36
        url 'https://prmaven.neoforged.net/NeoFormRuntime/pr36'
        content {
            includeModule('net.neoforged', 'neoform-runtime')
        }
    }
}

@shartte shartte marked this pull request as ready for review September 4, 2024 21:42
@shartte shartte requested a review from Matyrobbrt September 8, 2024 11:46
@shartte shartte merged commit 77bfe1a into main Sep 8, 2024
2 checks passed
@shartte shartte deleted the legacy branch September 8, 2024 11:53
@neoforged-releases
Copy link

🚀 This PR has been released as NeoFormRuntime version 1.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants