Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:select existing talk room for conversations on calendar events #6595

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat:select existing talk room for conversations on calendar events #6595

wants to merge 2 commits into from
+215 −7

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Dec 30, 2024

fixes #6581

@GretaD GretaD added the 2. developing Work in progress label Dec 30, 2024
@GretaD GretaD self-assigned this Dec 30, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 23.26%. Comparing base (86ad61e) to head (1ccf1d0).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/AddTalkModal.vue 0.00% 38 Missing ⚠️
src/views/EditSidebar.vue 0.00% 20 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6595      +/-   ##
============================================
- Coverage     23.40%   23.26%   -0.15%     
  Complexity      472      472              
============================================
  Files           249      250       +1     
  Lines         11901    11977      +76     
  Branches       2271     2282      +11     
============================================
  Hits           2786     2786              
- Misses         8788     8864      +76     
  Partials        327      327
Flag Coverage Δ
javascript 14.73% <0.00%> (-0.12%) ⬇️
php 59.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD changed the title feat:select existing talk roomfor convesations feat:select existing talk room for conversations on calendar events Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski will be requested when the pull request is marked ready for review SebastianKrupinski is a code owner

@st3iny st3iny Awaiting requested review from st3iny st3iny will be requested when the pull request is marked ready for review st3iny is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld will be requested when the pull request is marked ready for review tcitworld is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@GretaD GretaD

Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select existing Talk room for conversation, and streamline creation of new one
1 participant
@GretaD