Photos: directories with .nomedia files are scanned

[paullbn]

Hello,

Pictures located in directories containing a .nomedia files are scanned and displayed in Maps.

[jancborchardt]

Good point, they should be omitted, as probably all hidden folders and files.

[FelixBuehler]

Maybe even add an option to only scan specific folders. I have a lot of folders with no relevant data or photos in there but are quite big.
So a parameter like occ maps:scan-photos userX /Photos would be a good idea.

[jancborchardt]

@FelixBuehler we need to make sure that things we add work for regular people too. And it’s always best to do that automatically, without specific settings. :) A simpler fix could just be which folders are prioritized, e.g. well-known locations like a "Pictures" or "Photos" folder can be done first.

[FelixBuehler]

But why isn't a folder-name parameter working for all users? I mean the parameter could be optional. And if I set it, just my folder 'Photos' or 'Pics' or 'Cats' will be scanned.

[jancborchardt]

Most people do not change defaults or fiddle with settings. Hence we first have to focus on making sure it’s performant in the default case.

[SimpleRealDT]

found that external storage are also scanned, that a lot of cache picture from telegram or other application that shoot by others displayed in my nextcloud maps. excluding external storage or excluding some folders will be useful

[GAS85]

Any update here? Quite needed feature, otherwise I can see only tracks from backup of PhoneTrack App, but not actual one...

[schklom]

I made a PR #617, but didn't test it. Does anyone care to try building it to see if it works?
The new code is pretty staightforward 😃
Note that the indentation in the PR isn't the same as the one in the file, I don't understand why.

Hopefully it works 🚀

PS: yes, I like emojis

[Derkades]

Note that the indentation in the PR isn't the same as the one in the file, I don't understand why.

This is because you used tabs while the rest of the code uses spaces. Your text editor likely displays tabs as 4 spaces while github uses 8.

[schklom]

This is because you used tabs while the rest of the code uses spaces.

I didn't notice x) Thanks!
I updated the PR.

[b3nis]

It would be amazing to be able to choose which folders it scans. It's not usable for me now since it picks up so much stuff that I don't want.
Default could everything and then just have something under settings where I can pick which folders and re-scan.

With that this would be so freaking cool - I love the idea of the app!

[strugee]

@b3nis that sounds like a different feature request. Can you see if it's already on file and if not, open a new issue? You may want to link nextcloud/photos#141 too since it would probably make sense for these to share the same setting.

[b3nis]

@b3nis that sounds like a different feature request. Can you see if it's already on file and if not, open a new issue? You may want to link nextcloud/photos#141 too since it would probably make sense for these to share the same setting.

Sorry, my bad. Please ignore my comment nextcloud/photos#141 is exactly what I was looking for, will cheer on that discussion :-)

[AykutCevik]

Any chance that this will be fixed?

[tacruc]

Maybe an approach along the same line as: nextcloud/photos#944
is easy to implement.