🖼️📂 Limit Photos to a single folder + subtree #141

dermalikmann · 2020-01-20T15:29:24Z

I think it would be really nice to create an option where the user can select a single folder (like /Photos) and the app only scans this folder and its subfolders.

I have tons and tons of images all over my nextcloud, but only in /Photos are my, well, photos. And it's kind of a tedious task to create always a .nomedia file in all other directories.

Add Support to additional folders by changing reworking "Choose another folder" to "Add folder" #2343

The text was updated successfully, but these errors were encountered:

skjnldsv · 2020-01-21T09:13:27Z

@jancborchardt ?

jancborchardt · 2020-01-23T11:23:47Z

Yes, @Mikescops and I briefly talked about this at the Contributor Week as well. What we could go for:

We look for a "Photos" or "Pictures" folder in the root. If it exists, we take that.
We should also account for translations, ideally following the xdg-user-dirs translations.
If no such folder exists, we fall back to root.
We show a settings area in the bottom left with:

Showing files from Photos
and a button: ( Change folder )

That way it’s an automatic setup process but can still be adjusted later.

skjnldsv · 2020-01-23T12:15:47Z

I would say it doesn't cover my needs. I have multiple folders with pictures that I want to be shown. Android is using all available photos, no idea for other galleries. Could be nice to check what users expect before pushing such drastic changes :)

Also, just having a setting to include/exclude some folders is probably the easiest/most universal way to do? 🤷‍♀️

Mikescops · 2020-01-23T14:08:07Z

@skjnldsv the point of @jancborchardt during our discussion was to have the most easy and transparent way to have the folder setups. I agree include/exclude would be the prefered way (as it is done on the sync for desktop client) but Jan thought choosing a single folder and having a per default on the Photos folder is the easiest way.

skjnldsv · 2020-01-23T15:42:29Z

Defaut is indeed always preferable, I'm not arguing this part.
But a default automated config needs to be relevant. I'm not sure this is relevant to use a default Pictures or Photos folder.
Even our Nextcloud client have the default autoupload set to the InstantUpload folder, so we would not be compliant to our android setup :)

Mikescops · 2020-01-24T09:10:29Z

Let's take root folder but provide an option asap to restrict it to a given folder

bendschs · 2020-03-13T16:12:58Z

does .noimage apply to a folder and all subfolders or just the folder itself?

skjnldsv · 2020-03-18T20:11:06Z

does .noimage apply to a folder and all subfolders or just the folder itself?

folder and subfolders :)

bendschs · 2020-03-19T00:31:38Z

ok, in that case it simply does not work for me ... latest stable release of nextcloud 18

strugee · 2020-03-19T01:15:54Z

@bendschs please file a separate issue then. Make sure to search for duplicates beforehand.

kicker334 · 2020-06-13T14:25:41Z

Can this be developed? the .noimage/.nomedia trick isn't working for any of my folders.

jancborchardt · 2020-06-13T16:24:10Z

@kicker334 sure thing – are you interested in contributing? :)

kicker334 · 2020-06-14T02:56:21Z

@jancborchardt I honestly wouldn't know where to start, develop, or test this type of thing... :( I have to ask strangers on the internet for help.

naezeroth · 2020-07-09T05:39:20Z

I'd love to help out - I'm super new to this kind of thing but if I could get some starting tips I can definitely have a go!

artonge · 2024-01-22T17:13:10Z

@jancborchardt we already have a setting to configure upload directory for photos. I guess we should keep only one, right? Currently, the default value for this setting is the hard-coded string '/Photos'.

One limitation could be that a user could want the Photos app to show pictures from its root directory, while wanting new pictures to be uploaded in a specific one.

We can internationalize the default value with the way we usually do our translations.

szaimen · 2024-01-22T17:14:18Z

I would personally vote for a second config option as people might want to set these independently...

AndyScherzinger · 2024-01-22T17:18:40Z

We can internationalize the default value with the way we usually do our translations.

I wouldn't do that, on Android have have this -> AutoUpload folder is translated: So whenever you switch the language of the device, or have a new device or several with different languages it gets messy.

The only thing that comes to mind could be to have a way to display this fact as some meta info at the folder within the files app.

Just my 2 cents.

artonge · 2024-01-22T17:21:09Z

I wouldn't do that, on Android have have this -> AutoUpload folder is translated: So whenever you switch the language of the device, or have a new device or several with different languages it gets messy.

Translated on init would be enough, no?

AndyScherzinger · 2024-01-22T17:22:23Z

Translated on init would be enough, no?

Yes, that would be fine 👍

artonge · 2024-01-22T17:25:40Z

Should we also restric the search to the specified folder in other timeline views?

"Favories", "On this day", "Shared with you"
"Photos", I guess yes
"Videos", it do not make sense, does it?

Same question for automated collections:

"Places"
"Peoples"

artonge · 2024-01-25T17:24:58Z

@jancborchardt or @nimishavijay

nimishavijay · 2024-02-05T17:36:47Z

As discussed, the folders from which media is shown can be configurable, and the folder to which photos are added is just one. Then it totally makes sense to restrict the timeline views, favourites, etc to only the selected folders :)

It could look like this in the settings :)

folders in the root folder do not have the path in the subline, otherwise the 2 parent folders are shown in the subline, so if /Canon/Photography/2024/Portraits is selected, subline is Photography/2024

Nice-to-have little details:

show a different icon when the root folder is selected
don't allow removing the folder if there is only one folder selected

ccing @jancborchardt in case you had something different in mind and also to double-check the wording :)

Edit: changed wording of button ("Choose another folder" to "Add folder")

jancborchardt · 2024-02-06T09:34:23Z

@nimishavijay mockup looks great, we just need to make sure that the default for both Media folder and Upload folder is "Photos". :)

And one detail, instead of "Choose another folder" I would say "Add folder" because it’s not a switch-choice like for the upload folder.

sorbaugh · 2024-02-14T09:14:25Z

@nimishavijay @jancborchardt I agree with removing the limitiation of having only 1 folder, and the nice-to-haves look neat. I'm splitting this into a separate subtask to get the current "finished" PR merged and make the individual steps and progress more transparent!

EDIT:
See #2343

dermalikmann · 2024-02-19T21:12:08Z

🎉 🥳
Thx everyone!

jancborchardt · 2024-02-22T09:58:27Z

@dermalikmann thanks for the really nice (and popular) suggestion! :) We hope you will enjoy the upcoming release!

artonge · 2024-02-27T09:57:21Z

@tobiasKaminsky I guess this needs to be taken into account by mobile clients. The setting is stored as a user config. Not sure whether you can easily access those from the clients ?

melroy89 · 2024-05-16T08:43:26Z

OK.. interesting breaking change. Since now it gives me "No photos or videos in here" at all media & photos. While 1 user shared me folder with 10k images (basically all our personal/family photos), which I saw before. But not anymore ;(.

So I changed the media folder, to the shared folder we have (called "Photos & videos"). After selecting that folder, I get: " An error occurred ".

[ERROR] photos: Error fetching files 
Object { app: "photos", uid: "melroy", level: 3, error: Error }
photos-main.js:2:38563
    value https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    value https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    VueJS 2
    un https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    n https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    un https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    $emit https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    needContent https://cloud.melroy.org/apps/photos/js/photos-src_mixins_AbortControllerMixin_js-src_mixins_FilesSelectionMixin_js-src_components_File_vue--80ca54.js?v=043159e94cc23a1fb765:2
    un https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    n https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    un https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    $emit https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    visibleSections https://cloud.melroy.org/apps/photos/js/photos-src_mixins_AbortControllerMixin_js-src_mixins_FilesSelectionMixin_js-src_components_File_vue--80ca54.js?v=043159e94cc23a1fb765:2
    un https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    run https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    er https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    Fn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    gn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    (Async: promise callback)
    hn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    Fn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    tr https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    update https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    notify https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    set https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    set https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    resizeObserver https://cloud.melroy.org/apps/photos/js/photos-src_mixins_AbortControllerMixin_js-src_mixins_FilesSelectionMixin_js-src_components_File_vue--80ca54.js?v=043159e94cc23a1fb765:2
    (Async: ResizeObserverCallback)
    mounted https://cloud.melroy.org/apps/photos/js/photos-src_mixins_AbortControllerMixin_js-src_mixins_FilesSelectionMixin_js-src_components_File_vue--80ca54.js?v=043159e94cc23a1fb765:2
    un https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    Gn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    insert https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    k https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    ki https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    _update https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    r https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    get https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    run https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    er https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    Fn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    gn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    (Async: promise callback)
    hn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    Fn https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    tr https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    update https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    notify https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    set https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    init https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2
    init https://cloud.melroy.org/apps/photos/js/photos-main.js?v=d01aad25-1:2

ttrakker · 2024-07-08T08:10:57Z

@skjnldsv the point of @jancborchardt during our discussion was to have the most easy and transparent way to have the folder setups. I agree include/exclude would be the prefered way (as it is done on the sync for desktop client) but Jan thought choosing a single folder and having a per default on the Photos folder is the easiest way.

Easiest, not best. This degrades the system.

skjnldsv added 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request labels Jan 21, 2020

jancborchardt changed the title ~~Option to limit nc-photos search to a single folder + subtree~~ Limit Photos to a single folder + subtree Jan 23, 2020

jancborchardt mentioned this issue Jan 23, 2020

Add option to restrict scan to certain folder (recursively) nextcloud/maps#270

Open

skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 28, 2020

skjnldsv mentioned this issue Jan 28, 2020

Allow to browse the folder tree #142

Closed

This comment has been minimized.

Sign in to view

skjnldsv mentioned this issue Feb 26, 2020

Add some method to designate what folders/paths are included (or excluded) #209

Closed

This comment has been minimized.

Sign in to view

skjnldsv pinned this issue Mar 2, 2020

matiasdelellis mentioned this issue Mar 5, 2020

PNGs aren't recognized as photos #208

Closed

This was referenced Mar 5, 2020

Not taking into account the .noimage flag #75

Closed

Custom path for photos directory #228

Closed

Respect .noimage and .nomedia files #159

Merged

Queuecumber mentioned this issue May 5, 2020

.nomedia / .noimage file not respected within "Your photos" #234

Closed

AndyScherzinger changed the title ~~🖼️ Limit Photos to a single folder + subtree~~ 🖼️📂 Limit Photos to a single folder + subtree Jan 18, 2024

sorbaugh assigned artonge Jan 22, 2024

nextcloud unlocked this conversation Feb 6, 2024

artonge mentioned this issue Feb 6, 2024

Add config to select source directories #2319

Merged

8 tasks

nimishavijay moved this from 🏗️ At engineering to 🕶️ Design review in 🖍 Design team Feb 7, 2024

sorbaugh moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Feb 12, 2024

sorbaugh added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Feb 12, 2024

sorbaugh mentioned this issue Feb 14, 2024

Add Support to additional folders by changing reworking "Choose another folder" to "Add folder" #2343

Closed

artonge closed this as completed in #2319 Feb 15, 2024

github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Feb 15, 2024

github-project-automation bot moved this from 🕶️ Design review to 🎉 Done in 🖍 Design team Feb 15, 2024

thatguyatgithub mentioned this issue Apr 2, 2024

"No photos or videos in here" since latest 29 beta, still present at RC1 #2420

Closed

This comment was marked as spam.

Sign in to view

jkahrs mentioned this issue Oct 31, 2024

404 on Image Previews #2690

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🖼️📂 Limit Photos to a single folder + subtree #141

🖼️📂 Limit Photos to a single folder + subtree #141

dermalikmann commented Jan 20, 2020 •

edited by sorbaugh

Loading

skjnldsv commented Jan 21, 2020

jancborchardt commented Jan 23, 2020

skjnldsv commented Jan 23, 2020

Mikescops commented Jan 23, 2020

skjnldsv commented Jan 23, 2020 •

edited

Loading

Mikescops commented Jan 24, 2020

This comment has been minimized.

This comment has been minimized.

bendschs commented Mar 13, 2020

skjnldsv commented Mar 18, 2020

bendschs commented Mar 19, 2020

strugee commented Mar 19, 2020

kicker334 commented Jun 13, 2020

jancborchardt commented Jun 13, 2020

kicker334 commented Jun 14, 2020

naezeroth commented Jul 9, 2020

artonge commented Jan 22, 2024 •

edited

Loading

szaimen commented Jan 22, 2024

AndyScherzinger commented Jan 22, 2024

artonge commented Jan 22, 2024

AndyScherzinger commented Jan 22, 2024

artonge commented Jan 22, 2024

artonge commented Jan 25, 2024

nimishavijay commented Feb 5, 2024 •

edited

Loading

jancborchardt commented Feb 6, 2024 •

edited

Loading

sorbaugh commented Feb 14, 2024 •

edited

Loading

dermalikmann commented Feb 19, 2024

jancborchardt commented Feb 22, 2024

artonge commented Feb 27, 2024

melroy89 commented May 16, 2024 •

edited

Loading

This comment was marked as spam.

ttrakker commented Jul 8, 2024

🖼️📂 Limit Photos to a single folder + subtree #141

🖼️📂 Limit Photos to a single folder + subtree #141

Comments

dermalikmann commented Jan 20, 2020 • edited by sorbaugh Loading

skjnldsv commented Jan 21, 2020

jancborchardt commented Jan 23, 2020

skjnldsv commented Jan 23, 2020

Mikescops commented Jan 23, 2020

skjnldsv commented Jan 23, 2020 • edited Loading

Mikescops commented Jan 24, 2020

This comment has been minimized.

This comment has been minimized.

bendschs commented Mar 13, 2020

skjnldsv commented Mar 18, 2020

bendschs commented Mar 19, 2020

strugee commented Mar 19, 2020

kicker334 commented Jun 13, 2020

jancborchardt commented Jun 13, 2020

kicker334 commented Jun 14, 2020

naezeroth commented Jul 9, 2020

artonge commented Jan 22, 2024 • edited Loading

szaimen commented Jan 22, 2024

AndyScherzinger commented Jan 22, 2024

artonge commented Jan 22, 2024

AndyScherzinger commented Jan 22, 2024

artonge commented Jan 22, 2024

artonge commented Jan 25, 2024

nimishavijay commented Feb 5, 2024 • edited Loading

jancborchardt commented Feb 6, 2024 • edited Loading

sorbaugh commented Feb 14, 2024 • edited Loading

dermalikmann commented Feb 19, 2024

jancborchardt commented Feb 22, 2024

artonge commented Feb 27, 2024

melroy89 commented May 16, 2024 • edited Loading

This comment was marked as spam.

ttrakker commented Jul 8, 2024

dermalikmann commented Jan 20, 2020 •

edited by sorbaugh

Loading

skjnldsv commented Jan 23, 2020 •

edited

Loading

artonge commented Jan 22, 2024 •

edited

Loading

nimishavijay commented Feb 5, 2024 •

edited

Loading

jancborchardt commented Feb 6, 2024 •

edited

Loading

sorbaugh commented Feb 14, 2024 •

edited

Loading

melroy89 commented May 16, 2024 •

edited

Loading