Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure languages used for spell checking #771

Open
st3iny opened this issue Aug 26, 2024 · 3 comments · May be fixed by #855
Open

Configure languages used for spell checking #771

st3iny opened this issue Aug 26, 2024 · 3 comments · May be fixed by #855
Assignees
Labels
2. developing enhancement New feature or request

Comments

@st3iny
Copy link
Member

st3iny commented Aug 26, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Currently, the spell checker defaults to the system's language on Linux. In my case this is German. However, I mostly communicate in English on Talk and the spell checker constantly shows the red underline below each word because it doesn't understand English.

image

Describe the solution you'd like
Let users configure languages used for spell checking.

Describe alternatives you've considered
Change my system's language. This won't fix the issue as I'm communication both in German and English regularly in Talk.

Additional context
Here is a hack I'm currently using that works:

diff --git a/src/talk/talk.window.js b/src/talk/talk.window.js
index 6d69246..680847b 100644
--- a/src/talk/talk.window.js
+++ b/src/talk/talk.window.js
@@ -67,6 +67,9 @@ function createTalkWindow() {
        applyWheelZoom(window)
        setupTray(window)

+       // Configure the spell checker to use English (US) and German
+       window.webContents.session.setSpellCheckerLanguages(['en-US', 'de'])
+
        window.loadURL(TALK_WINDOW_WEBPACK_ENTRY)

        return window
@ShGKme
Copy link
Contributor

ShGKme commented Aug 26, 2024

A simple solution - use system language + Nextcloud user settings.

An alternative - provide a setting with the list of all the options.

@ShGKme
Copy link
Contributor

ShGKme commented Aug 26, 2024

Will go with use system languages as the default + local settings.

@ShGKme ShGKme linked a pull request Oct 28, 2024 that will close this issue
1 task
@ShGKme ShGKme self-assigned this Oct 30, 2024
@schiessle
Copy link
Member

schiessle commented Dec 11, 2024

I think there should be also a easy way to switch the language. On the browser I can right-click into the input field and select one or multiple languages. This is really helpful if you switch regular between languages. As the desktop app also uses some kind of an "embedded browser" I wonder if there is a way to expose this language switcher?

Maybe I'm special in this regard but both my operating system and Nextcloud are set to English but I also have chats regularly in German. So a easy way to switch the spell checker would be really helpful, or set it to check for both languages by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants