-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Nextcloud App "Optical character recognition" https://github.com/janis91/ocr #69
Comments
Hi @herrep, adding package is no problem, at least when they are provided by the distro. Please open a pull request and add necessary packages to the block at https://github.com/nextcloud/univention-app/blob/master/Dockerfile#L34-L60 |
That plugin is too old now and I suggest switching to https://apps.nextcloud.com/apps/workflow_ocr |
This would blow the image, I suppose, and I already have mixed feelings about additional php modules. I solution I would rather fancy is some mechanism to allow admins to specifiy additional packages that would be installed with each installation / image upgrade. This could be doable through some ucr entry, that will be checked in the setup script (first idea coming to my mind, not necessarily best idea). |
As for me, it would be acceptable. I would use this mechanism. Though, it's not elegant, but would work. Another alternative is a full operational post-install script, I think. It gives more flexibility, but is more difficult to implement. And I think, it should be more universal, applicable also to another apps. |
Just tested installing ocrmypdf on the fresh released 25.0.8 container, and it looked nicer:
|
We could have an ucr entry like nextcloud/container/extra-packages (like https://github.com/nextcloud/univention-app/blob/master/inst#L125) which is by default empty, and expect to carry a space seperated list of packages we can pass on to apt install (after an apt update in case is not empty). The check and execution can be placed somewhere at the end of the setup script, ideally before placing the cron file. It should not be breaking however, log on error, but otherwise continue. |
are the possibility to rerun script or reinstall Nextcloud container after changing of UCR Value?
Why not at the beginning? As I understand, this script makes preadjustments to Nextcloud itself. Shouldn't preadjustments to its system be before it? |
Might be possible with some hooks through UCS. But would that be necessary at all? It's a rare action.
For then we have a known and defined state to set up or update Nextcloud. |
As I understand the install order:
And then there is also a situation, when an admin later decides to use some new addons, which requires again some packages. |
The variables can be set up front, before 1.
Yeah, that would be an |
will setting the ucr variable the persist across updates? |
Setting an ucr entry is done on the host and yes "survives" updates. |
Dear App Maintainer,
Would you consider support for integrating the Nextcloud App "Optical character recognition" available at https://github.com/janis91/ocr into your Nextcloud Docker Container?
When activating this Nextcloud App, I need to add further packages to be run locally in the Nextcloud Docker Container and this breaks later updates of Nextcloud.
If there are no plans to do so, what would be the best way forward to integrate the Nextcloud App "Optical character recognition" or is the only way of installing Nextcloud directly within UCS 4.3?
Best regards,
Peter
The text was updated successfully, but these errors were encountered: