Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NgModule API #100

Open
mlc-mlapis opened this issue Jan 9, 2023 · 0 comments
Open

Support for NgModule API #100

mlc-mlapis opened this issue Jan 9, 2023 · 0 comments

Comments

@mlc-mlapis
Copy link
Contributor

mlc-mlapis commented Jan 9, 2023

I'm submitting a ...

[x] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  

Current behavior

Building an Angular application migrated already to 15.0.4 with @ngneat/error-tailor 2.2.2 works as expected.
After updating to @ngneat/error-tailor 3.0.3 the build completely collapsed. It seems that ErrorTailorModule is not available at all.

Expected behavior

@NetanelBasal The build should still work with @ngneat/error-tailor 3.0.3 and be compatible with the NgModule convention.

What is the motivation / use case for changing the behavior?

The Standalone Component API in Angular v15 is not a breaking change. It's only an optional feature, and NgModule API is still and will be fully supported. The new version of @ngneat/error-tailor shouldn't require changing the actual structure of applications, including using the bootstrapApplication sequence.

Environment


Angular version: 15.0.4


Browser:
- any
 
For Tooling issues:
- Node version: 16.14.0
- Platform:  any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant