From 9642024958873c9ca8171847a5ecaa52959d9bc0 Mon Sep 17 00:00:00 2001 From: bpinsard Date: Thu, 31 Oct 2024 10:45:49 -0400 Subject: [PATCH 1/2] pin nibabel version to avoid a bunch of enhanced dicoms issues, notably through dcmstack --- heudiconv/info.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/heudiconv/info.py b/heudiconv/info.py index 74deecf2..9a5ce3ce 100644 --- a/heudiconv/info.py +++ b/heudiconv/info.py @@ -27,7 +27,7 @@ "dcmstack>=0.8", "etelemetry", "filelock>=3.0.12", - "nibabel", + "nibabel>=5.3.1", "nipype >=1.2.3", "pydicom >= 1.0.0", ] From a3d69d8b1191ee58947618f75ca35dc039cd3e8d Mon Sep 17 00:00:00 2001 From: bpinsard Date: Thu, 31 Oct 2024 14:44:14 -0400 Subject: [PATCH 2/2] deprecate py3.8 --- .github/workflows/lint.yml | 2 +- .github/workflows/release.yml | 2 +- .github/workflows/test.yml | 1 - .github/workflows/typing.yml | 2 +- heudiconv/info.py | 3 +-- 5 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 1d270e42..50dc267a 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -16,7 +16,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: '3.8' + python-version: '3.9' - name: Install dependencies run: | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 199015fe..90dff2dc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -40,7 +40,7 @@ jobs: if: steps.auto-version.outputs.version != '' uses: actions/setup-python@v5 with: - python-version: '^3.8' + python-version: '^3.9' - name: Install Python dependencies if: steps.auto-version.outputs.version != '' diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a640917a..a9e35028 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,7 +17,6 @@ jobs: fail-fast: false matrix: python-version: - - '3.8' - '3.9' - '3.10' - '3.11' diff --git a/.github/workflows/typing.yml b/.github/workflows/typing.yml index c01c56cb..dd8a09e5 100644 --- a/.github/workflows/typing.yml +++ b/.github/workflows/typing.yml @@ -16,7 +16,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: '3.8' + python-version: '3.9' - name: Install dependencies run: | diff --git a/heudiconv/info.py b/heudiconv/info.py index 9a5ce3ce..e2ad1e94 100644 --- a/heudiconv/info.py +++ b/heudiconv/info.py @@ -11,7 +11,6 @@ "Environment :: Console", "Intended Audience :: Science/Research", "License :: OSI Approved :: Apache Software License", - "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", @@ -19,7 +18,7 @@ "Typing :: Typed", ] -PYTHON_REQUIRES = ">=3.8" +PYTHON_REQUIRES = ">=3.9" REQUIRES = [ # not usable in some use cases since might be just a downloader, not binary