New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid JSON fails to parse #72

Open

jordaaash opened this issue Jun 10, 2016 · 1 comment

Labels

bug

jordaaash commented Jun 10, 2016 •

edited

Loading

Any ' in the script will cause the JSON parser to fail.

package.json

{
    "pre-push#production": [ "pre-push" ],
    "scripts": {
        "pre-push": "echo \"don't push to production, open a pull request\"; exit 1"
    }
}

shell

git:(production) > git push
running pre-push...failed!
.git/hooks/pre-push: eval: line 235: unexpected EOF while looking for matching `''
.git/hooks/pre-push: eval: line 236: syntax error: unexpected end of file

The text was updated successfully, but these errors were encountered:

Owner

nlf commented Jun 15, 2016

interesting. i'll see what i can do

nlf added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment