Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOOS-914/ai-pr-review #44

Merged
merged 4 commits into from
Oct 9, 2024
Merged

NOOS-914/ai-pr-review #44

merged 4 commits into from
Oct 9, 2024

Conversation

zyassine
Copy link
Contributor

@zyassine zyassine commented Oct 7, 2024 •
edited
Loading

SEMVER Update Type:

  • Major
  • Minor
  • Patch

Description:

Motivation:

Closes Issues:

Checklist:

  • All new jobs, commands, executors, parameters have descriptions.
  • Usage Example version numbers have been updated.
  • Changelog has been updated.

@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch 11 times, most recently from 4cda50f to 9351591 Compare October 7, 2024 16:06
@zyassine zyassine requested a review from a team as a code owner October 7, 2024 16:06
@zyassine zyassine added the ⚠️ WIP ⚠️ PR currently being worked on. label Oct 7, 2024
@zyassine zyassine self-assigned this Oct 7, 2024
@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch from 9351591 to c837ff3 Compare October 7, 2024 23:18
pieeri
pieeri requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@pieeri pieeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓

.circleci/test-deploy.yml Outdated Show resolved Hide resolved
src/commands/github_post_comment.yml Show resolved Hide resolved
.github/workflows/pr_agent_template.yml Outdated Show resolved Hide resolved
@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch 9 times, most recently from 6344094 to 90c6262 Compare October 8, 2024 14:50
@noosenergy noosenergy deleted a comment from noosenergy-ci Oct 8, 2024
@noosenergy noosenergy deleted a comment from noosenergy-ci Oct 8, 2024
@noosenergy noosenergy deleted a comment from noosenergy-ci Oct 8, 2024
@noosenergy noosenergy deleted a comment from noosenergy-ci Oct 8, 2024
@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch from 90c6262 to a148350 Compare October 8, 2024 15:34
@noosenergy-ci
Copy link
Member

/review

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Persistent review updated to latest commit 4cdf289

@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch from 4cdf289 to 5024923 Compare October 8, 2024 16:50
@noosenergy-ci
Copy link
Member

/review

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Persistent review updated to latest commit 5024923

@zyassine zyassine added 🚢 Ready to ship 🚢 PR ready to be merged, once approved. and removed ⚠️ WIP ⚠️ PR currently being worked on. labels Oct 8, 2024
@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch from 320f4f8 to 38cb231 Compare October 8, 2024 18:56
@zyassine zyassine requested a review from pieeri October 8, 2024 18:57
@noosenergy-ci
Copy link
Member

/review

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Persistent review updated to latest commit 38cb231

pieeri
pieeri requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@pieeri pieeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually the PR Agent is alive! Thanks for throwing the time in to make it work!

src/commands/github_post_comment.yml Outdated Show resolved Hide resolved
.circleci/test-deploy.yml Show resolved Hide resolved
@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch from 38cb231 to f155d30 Compare October 9, 2024 08:07
@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch from f155d30 to 7b40cb7 Compare October 9, 2024 08:09
@noosenergy-ci
Copy link
Member

/review

@zyassine zyassine requested a review from pieeri October 9, 2024 08:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Persistent review updated to latest commit 7b40cb7

@zyassine zyassine force-pushed the NOOS-914/ai-pr-review branch from 7b40cb7 to de36bca Compare October 9, 2024 09:20
pieeri
pieeri approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@pieeri pieeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship!

@mthiboust mthiboust requested review from pieeri and mthiboust October 9, 2024 09:21
mthiboust
mthiboust approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mthiboust mthiboust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use it now!

@noosenergy noosenergy deleted a comment from noosenergy-ci Oct 9, 2024
@zyassine zyassine merged commit 3da7130 into master Oct 9, 2024
2 checks passed
@zyassine zyassine deleted the NOOS-914/ai-pr-review branch October 9, 2024 09:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Persistent review updated to latest commit de36bca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthiboust mthiboust mthiboust approved these changes

@pieeri pieeri Awaiting requested review from pieeri

Assignees

@zyassine zyassine

Labels
🚢 Ready to ship 🚢 PR ready to be merged, once approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zyassine @noosenergy-ci @pieeri @mthiboust