Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structlog levels don't respect python logging levels #76

Open
MSeal opened this issue Nov 18, 2022 · 0 comments
Open

structlog levels don't respect python logging levels #76

MSeal opened this issue Nov 18, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@MSeal
Copy link
Member

MSeal commented Nov 18, 2022

Describe the bug
By default our structlogs are printing debug messages, which are quite noisy. The standard pattern of setting log levels using the logging library isn't being respected, thus it's hard to know how to tune the second config of logging present.

To Reproduce
Steps to reproduce the behavior:

  1. Run any notebook
  2. See debug logs
  3. Change logging level
  4. Still see debug logs
  5. Change structlog levels
  6. See debugs go away

Expected behavior
The papermill cli and logging library levels should be the defaults when starting struct logs. We may need to scan log levels and pass them along when we initialize structlog.

@MSeal MSeal added the bug Something isn't working label Nov 18, 2022
@rohitsanj rohitsanj self-assigned this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants