Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great site and product! Some tests would be nice, though. #116

Open
joel-s opened this issue Oct 19, 2024 · 1 comment
Open

Great site and product! Some tests would be nice, though. #116

joel-s opened this issue Oct 19, 2024 · 1 comment

Comments

@joel-s
Copy link

joel-s commented Oct 19, 2024

The code I looked at (while searching for a useDownload hook) looked well thought-out and useful.

OTOH, all the code I commit at work (especially library-like code like this) needs to have tests that achieve a high percentage of code coverage. Just thought I should mention this, since it was the only obstacle to copying and pasting a bunch of code from your excellent site. Is that something you might add? (Something you would like help with?)

@joel-s joel-s changed the title Great idea! Some tests would be nice Great site and product! Some tests would be nice, though. Oct 19, 2024
@dlcastillop
Copy link
Member

Hi Joel, I'm glad you like Nova.js. I'd be lying if I said I haven't considered adding tests to this repo and then in the documentation somehow pointing out that the code has been tested and adding some link to them.

I'm currently working on improving the documentation and adding more examples. Maybe you can help with the tests, if you want and have time of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants