Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed ByteFlow and FlowInfo #84

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Removed ByteFlow and FlowInfo #84

wants to merge 22 commits into from

Conversation

kc611
Copy link
Contributor

@kc611 kc611 commented Jul 7, 2023

Resolves #75

This PR builds on top of #83 and removes ByteFlow and FlowInfo classes. The respective methods are shifted to SCFG objects hence simplifying graph building and rendering.

kc611 and others added 22 commits June 29, 2023 17:09
@kc611
Added from_yaml, to_yaml, from_dict and to_dict conversion for new fo…
63e1194 
…rmat
@kc611
Refactored test suite to match the new functions
1d9689a
@kc611
Added region identification and printing capabilities to to_yaml and …
dae773c 
…to_dict
@kc611
Adapted tests to the changes
0ea0e6c
@kc611
Fixed no head detected test failure
4213e58
@kc611
Added block type identification capability to from_dict and from_yaml
1f5d955
@kc611
Added yaml based block building capabilities to SCFG
ac2802e
@kc611
Automated Bahmann paper figure tests
7a3b4c2
@kc611
Adapted test suite to changes
e1097ad
@esc
refactor YAML writing to use indent for readability
fcdc9b9 
As title
@kc611 @esc
Apply suggestions from code review
8cd3009 
Co-authored-by: esc <[email protected]>
@kc611
Used isinstance instead of string comparison in to_dict method
462c716
@kc611
Added equality assertions for synthetic assignments and synthetic bra…
e4dd79c 
…nching properties
@kc611
Changed jump targets and backedges replacement login in basic blocks
d7e907b
@kc611
Adapted core datastructures to basic block logic changes
d28a326
@kc611
Adapted transformations to basic block changes
0b95844
@kc611
Adapted rendering to basic block changes
7ce552e
@kc611
Adapted tests to basic block changes
f04eeb9
@kc611
Removed Byteflow and FlowInfo and moved respective methods to SCFG
2c68abf
@kc611
Simplified graph rendering
018aa54
@kc611
Adapted tests according to the changes
9000b38
@kc611
Adapted simulator to changes
709453e
@sklam
Copy link
Member

sklam commented Jul 10, 2023

The refactoring is ok but i'm seeing miscompilation in testing #9012 once i switch to this patch. I will test again once this PR is stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Remove ByteFlow and FlowInfo classes.
3 participants
@kc611 @sklam @esc