-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefix vars to avoid namespace clashes #77
Comments
Note that DebOps has a procedure in place to do variable renames (ref: Migration/upgrade notes) so this could be semi-automated and users only have to run a command. About the name, I would not mind so much to keep the variable names to a minimum but that might come from my practice to copy/paste variables from the default file and then modifying them. Also, I would prefer a more descriptive role name which could then also be used for the variables, like If the only reason to not use @nusenu BTW: I like how you handle the release management 😉 |
freebsd_somaxconn -> tor_freebsd_somaxconn freebsd_nmbclusters -> tor_freebsd_nmbclusters v4tmp -> tor_v4tmp
ipv4_count -> tor_ipv4_count v6tmp -> tor_v6tmp
dupcount -> tor_dupkeycount currentsomaxconn -> tor_currentsomaxconn currentnmbc -> tor_currentnmbc currentlimits -> tor_openbsd_maxfiles
instances -> tor_instances_tmp masterkeycheck -> tor_masterkeyonline rsakey -> tor_rsakey_match ipsinterm -> tor_ipsinterm
Follow best practices and prefix your role variables.
mentioned in #75 and
https://galaxy.ansible.com/intro
I find "relayor_" a rather long prefix and would prefer "tor_" or "torr_" (short tor relay), because I guess it is unlikely that people will run multiple tor roles.
Note: This change will break existing setups since they will have to update their playbooks.
For this reason we will commit this once we start to require tor v0.2.8.x (see #71 )
The text was updated successfully, but these errors were encountered: