Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Maintainers #345

Open
theHamsta opened this issue Dec 22, 2022 · 7 comments
Open

Call for Maintainers #345

theHamsta opened this issue Dec 22, 2022 · 7 comments

Comments

@theHamsta
Copy link
Member

theHamsta commented Dec 22, 2022

I'm not using nvim-treesitter-textobjects that frequently and I'm a bit short on time to implement urgently needed features and refactorings for this plugin.

@kiyoon was already helping already a lot to revive this project. Thank you again!

We had some ideas on open task discussed here:
#329 (comment), #329 (comment) . Essentially,

  • use Neovim's native query API instead of slow nvim-treesitter.query
  • simplify spaghetti code in the code base
  • add tests
  • implement long open feature request

If you have some open cycles feel free to ping me or comment here if you want to get involved! You don't have to spend a lot of time. Just have a look at open issues from time to time to see whether there is some small thing that you can fix. Shared work is less work for everyone 🙂

@theHamsta theHamsta pinned this issue Dec 22, 2022
@clason
Copy link
Collaborator

clason commented Dec 22, 2022

Long-term (after much needed cleanup) we could think about upstreaming this into nvim-treesitter itself (combining this with the incremental-selection module, which conversely could also be included in this repo).

Regarding tests: a particular pain point is that we currently don't catch parser updates in nvim-treesitter that break nvim-treesitter-textobjects queries; this would be another (separate) issue that could be worked on.

@theHamsta
Copy link
Member Author

We should at least make sure that we don't upstream (more) bad/legacy code to nvim-treesitter and do some clean up before. No big concerns about upstreaming the queries.

@clason
Copy link
Collaborator

clason commented Dec 22, 2022

Yes, that's why I wrote "after cleanup" ;)

@skbolton
Copy link
Contributor

skbolton commented Feb 8, 2023

Working on getting more involved in this project and would love to help out any way that I can.

@quantumfate
Copy link

I'm gonna submit a PR soon trying to add a new feature.

@ilan-schemoul
Copy link
Contributor

Can we have a status update on if the package is still maintained. Because I think it's an useful package used by thoushands (or at least starred by ~2K).
@clason @kiyoon are you still interested to maintain this package
Can you merge some PRs (at least the ones that won't take you too much time to review :) )

@clason
Copy link
Collaborator

clason commented Apr 1, 2024

Status update is: blocked by #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants