Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run on iOS 12 in 5.0.8 #363

Open
Igor-Palaguta opened this issue Nov 28, 2022 · 6 comments
Open

Unable to run on iOS 12 in 5.0.8 #363

Igor-Palaguta opened this issue Nov 28, 2022 · 6 comments

Comments

@Igor-Palaguta
Copy link

Igor-Palaguta commented Nov 28, 2022

We add NYTPhotoViewer using Cocopods and in 5.0.8 appeared an issue during application launch

dyld: Library not loaded: /System/Library/Frameworks/LinkPresentation.framework/LinkPresentation
  Referenced from: XXXX/Frameworks/NYTPhotoViewer.framework/NYTPhotoViewer
  Reason: image not found
@philipborbon
Copy link

philipborbon commented Feb 8, 2023

Hi Igor, Did you managed to get this resolved?

@Igor-Palaguta
Copy link
Author

Hi @philipborbon , I remember some API from LinkPresentation (not available in iOS 12) was used in 5.0.8, I switched to previous version. Probably weak linking of LinkPresentation should fix the issue

@philipborbon
Copy link

Thanks for the info.

I got it working as suggested also in this thread "Xcode 13 does not weak link LinkPresentation framework?".

"Manually adding LinkPresentation.framework to Link Binary with Libraries build phase, and setting its status to Optional."

Adding it in Pods > NYTPhotoViewer.framework target did the trick.

@StainlessStlRat
Copy link

Is the project not being maintained anymore?

@Igor-Palaguta
Copy link
Author

@philipborbon or we can add to Podfile:

post_install do |installer|
  installer.pods_project.targets.each do |target|
    if target.name == "NYTPhotoViewer"
      target.build_configurations.each do |config|
        config.build_settings['OTHER_LDFLAGS'] ||= ['-weak_framework', 'LinkPresentation']
        config.build_settings['OTHER_LDFLAGS'] << '$(inherited)'
      end
    end
  end
end

@Igor-Palaguta
Copy link
Author

Igor-Palaguta commented Oct 24, 2024

PR with fix #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants