Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxon disjointness unsat not showing up in pipeline #2707

Closed
shawntanzk opened this issue Oct 31, 2022 · 3 comments · Fixed by #3102
Closed

Taxon disjointness unsat not showing up in pipeline #2707

shawntanzk opened this issue Oct 31, 2022 · 3 comments · Fixed by #3102

Comments

@shawntanzk
Copy link
Collaborator

See #2702

From @balhoff

It means taxon constraints are not set up correctly. Four things are needed:

taxon constraints in ontology
robot expansions (only for never_in_taxon)
import of taxonomy hierarchy
import of taxonomy in_taxon sibling disjointness

Assigning myself for now, but to discuss in tech support group call

@shawntanzk shawntanzk self-assigned this Oct 31, 2022
@shawntanzk
Copy link
Collaborator Author

@anitacaron - I don't think I'll be around many mondays, going to assign this to you instead, could you bring up on tech call please? thanks :)

@anitacaron
Copy link
Collaborator

@balhoff, I'm working on this now. One of the steps is "import of taxonomy in_taxon sibling disjointness", but in the OBO Academy docs about taxonomy it says:

import http://purl.obolibrary.org/obo/ncbitaxon/subsets/taxslim-disjoint-over-in-taxon.owl (or implement a way to generate the needed disjointness axioms)
Note: that file only covers a subset of the taxonomy, and is missing (in_taxon some X) DisjointWith (in_taxon some (not X)). You may need to implement a way to generate the needed disjointness axioms until this is corrected.

How can I implement that?

@balhoff
Copy link
Member

balhoff commented Jun 15, 2023

@anitacaron you can use this SPARQL update: https://github.com/geneontology/go-ontology/blob/master/src/sparql/add-taxon-disjoints.ru

Or we can implement this issue at the source: obophenotype/ncbitaxon#72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants