Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9 support #20

Open
yobottehg opened this issue Jun 13, 2022 · 3 comments
Open

Laravel 9 support #20

yobottehg opened this issue Jun 13, 2022 · 3 comments

Comments

@yobottehg
Copy link

I don't think there should be issues with laravel 9 support, so would it be okay to allow for ìlluminate/support 9.x?

"illuminate/support": "^7.0 || ^8.0"
would then be :
"illuminate/support": "^7.0 || ^8.0 || ^9.0"

@yassir63
Copy link

Yes, it is totally okay as if you update to Laravel 9 you may find it in the composer.lock file or composer.json file

@yobottehg
Copy link
Author

yobottehg commented Jun 15, 2022

I think you misunderstood :)

It's not possible right now as the constraints in the composer.json needs to be adjusted:

composer require octoper/statamic-inline-assets
Info from https://repo.packagist.org: #StandWithUkraine
Using version ^4.0 for octoper/statamic-inline-assets
./composer.json has been updated
Running composer update octoper/statamic-inline-assets
> Statamic\Console\Composer\Scripts::preUpdateCmd
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - octoper/statamic-inline-assets[4.0.2, ..., 4.0.3] require illuminate/support ^7.0 || ^8.0 -> found illuminate/support[v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires octoper/statamic-inline-assets ^4.0 -> satisfiable by octoper/statamic-inline-assets[4.0.2, 4.0.3].

Project is laravel 9 but laravel 9 requires illuminate/support:^9.0

@espenlg
Copy link

espenlg commented Oct 12, 2022

Any change of this getting solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants