Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remote control graphic highlights not aligning with buttons #92

Open
wedebe opened this issue Apr 22, 2023 · 8 comments
Open

[BUG] Remote control graphic highlights not aligning with buttons #92

wedebe opened this issue Apr 22, 2023 · 8 comments

Comments

@wedebe
Copy link

wedebe commented Apr 22, 2023

Originally posted at github.com/openatv/enigma2/issues/2824.

The XML template for Mut@nt (also known as Ax) HD51 original remote control need fixing. The highlights are not aligning with the buttons.

'AX HD51'
'Mutant HD51'

Screenshot 2023-04-22 at 12 42 17

12:36:51.7426 [InputDevice] Default remote control identified as 'Mutant HD51'.  (model='hd51', rcName='hd1100', rcType='16')
12:36:51.7433 [InputDevice] Loading remote control '/usr/share/enigma2/hardware/hd1100.xml'.
12:36:51.7447 [InputDevice] Remote control image file 'None'.
12:36:45.1690 [eInit] + (21) input device driver
12:36:45.1690 [eInputDeviceInit] adding device /dev/input/event0
12:36:45.1692 [eRCInputEventDriver] EVIOCGRAB: Function not implemented
12:36:45.1692 [eRCDeviceInputDev] device "dreambox advanced remote control (native)" is a remotecontrol
12:36:45.1693 [eInputDeviceInit] adding device /dev/input/event1
12:36:45.1693 [eRCInputEventDriver] devicename=dreambox advanced remote control (native)
12:36:45.1693 [eRCInputEventDriver] devicename=dreambox advanced remote control (native)
12:36:45.1694 [eRCInputEventDriver] EVIOCGRAB: Function not implemented
12:36:45.1694 [eRCDeviceInputDev] device "dreambox advanced remote control (native)" is a remotecontrol

Originally posted by @IanSav in openatv/enigma2#2818 (comment)

@AbuBaniaz
Copy link
Contributor

@IanSav Can you share the tools/method to fix these so that @wedebe can correct the file?

@IanSav
Copy link
Contributor

IanSav commented Apr 22, 2023

I do the corrections manually. I test the results with the HELP diagnostic tool. (Long press HELP in any HELP screen.)

@IanSav
Copy link
Contributor

IanSav commented Apr 22, 2023

I just finished refactoring AVSwitch and I have some time before @jbleyel gets home and proof-reads that code. I will take a look at fixing this remote control.

@IanSav
Copy link
Contributor

IanSav commented Apr 22, 2023

What codes do the following buttons emit:
SLEEP
PORTAL
"|<<"
">>|"

@jbleyel
Copy link
Contributor

jbleyel commented Apr 22, 2023

Hi @wedebe , sorry for confusing.
The correct repro for ATV remotes is this ->

https://github.com/oe-alliance/remotes

@IanSav
Copy link
Contributor

IanSav commented Apr 22, 2023

I have had a guess at the missing buttons. Please test the new definitions and let me know if any corrections are required.

oe-alliance/remotes#13

@wedebe
Copy link
Author

wedebe commented Apr 23, 2023

What codes do the following buttons emit: SLEEP PORTAL "|<<" ">>|"

SLEEP
12:07:43.0333 [eRCDeviceInputDev] 1 8e 1
12:07:43.0367 [InfoBarGenerics] Key 'KEY_SLEEP' (142) Make.
12:07:43.2372 [eRCDeviceInputDev] 0 8e 1
12:07:43.2375 [InfoBarGenerics] Key 'KEY_SLEEP' (142) Break.
12:07:43.2378 [Screen] Showing screen 'UnhandledKey'.

PORTAL/CONTEXT
12:07:45.6230 [eRCDeviceInputDev] 1 9c 1
12:07:45.6236 [InfoBarGenerics] Key 'KEY_BOOKMARKS' (156) Make.
12:07:45.8292 [eRCDeviceInputDev] 0 9c 1
12:07:45.8297 [InfoBarGenerics] Key 'KEY_BOOKMARKS' (156) Break.
12:07:45.8301 [Screen] Showing screen 'UnhandledKey'.

|<<
12:07:48.6992 [eRCDeviceInputDev] 1 a5 1
12:07:48.6998 [InfoBarGenerics] Key 'KEY_PREVIOUSSONG' (165) Make.
12:07:49.0132 [eRCDeviceInputDev] 0 a5 1
12:07:49.0136 [InfoBarGenerics] Key 'KEY_PREVIOUSSONG' (165) Break.
12:07:49.0140 [Screen] Showing screen 'UnhandledKey'.

>>|
12:07:50.9587 [eRCDeviceInputDev] 1 a3 1
12:07:50.9593 [InfoBarGenerics] Key 'KEY_NEXTSONG' (163) Make.
12:07:51.1652 [eRCDeviceInputDev] 0 a3 1
12:07:51.1657 [InfoBarGenerics] Key 'KEY_NEXTSONG' (163) Break.
12:07:51.1661 [Screen] Showing screen 'UnhandledKey'.

@IanSav
Copy link
Contributor

IanSav commented Apr 23, 2023

I have now corrected the PORTAL button to be KEY_BOOKMARKS. When you get the next update, do all the buttons now work in the UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants