Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MELD graph traversal key names blackList/whiteList #1

Open
1 of 4 tasks
gklyne opened this issue Nov 24, 2020 · 3 comments
Open
1 of 4 tasks

Change MELD graph traversal key names blackList/whiteList #1

gklyne opened this issue Nov 24, 2020 · 3 comments
Labels
TODO Task to be done

Comments

@gklyne
Copy link
Collaborator

gklyne commented Nov 24, 2020

Changing names of blackList/whiteList in meld core codebase  (dev branch), as these have unfortunate connotations for some.

E.g. use:

Plan:

  • propose new names; e.g. followProperties / ignoreProperties
  • discuss new name choices with team
  • apply name changes to codebase
  • see if anything breaks

Ideally, this would be done with a test suite in place, but discussions indicate that the name change needs to be done sooner rather than later, so we may just have to push ahead.

@gklyne gklyne added the TODO Task to be done label Nov 24, 2020
@gklyne
Copy link
Collaborator Author

gklyne commented Dec 8, 2020

I'm proposing the following name changes:

- objectPrefixWhitelist    -> expandObjectPrefix
- objectUriWhitelist       -> expandObjectUri
- objectTypeWhitelist      -> expandObjectType
- objectPrefixBlacklist    -> ignoreObjectPrefix
- objectUriBlacklist       -> ignoreObjectUri
- objectTypeBlacklist      -> ignoreObjectType
- propertyPrefixWhitelist  -> followPropertyPrefix
- propertyUriWhitelist     -> followPropertyUri
- propertyPrefixBlacklist  -> ignorePpropertyPrefix
- propertyUriBlacklist     -> ignorePropertyUri 

@gklyne
Copy link
Collaborator Author

gklyne commented Dec 11, 2020

Comment received from @musicog (via Slack):

I would be careful with "expand" since its meaning is overloaded in jsonld-world. Maybe "include"? "fetch"? (both of those are overloaded in more general javascript as well, of course...)

@gklyne
Copy link
Collaborator Author

gklyne commented Dec 15, 2020

Proposing "extend" instead of "expand".

(Work-in-progress PR at oerc-music/meld-clients-core#16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO Task to be done
Projects
None yet
Development

No branches or pull requests

1 participant