Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icmr_sample route is broken #2615

Closed
yash-learner opened this issue Nov 25, 2024 · 2 comments
Closed

icmr_sample route is broken #2615

yash-learner opened this issue Nov 25, 2024 · 2 comments
Assignees

Comments

@yash-learner
Copy link
Member

yash-learner commented Nov 25, 2024

Describe the bug
Clicking the ICMR Specimen Referral Form button from a sample page takes to patient test sample page (patient/.../test_sample/.../icmr_sample) which results in internal server error

To Reproduce
Steps to reproduce the behavior:

  1. Click Sample Test tab in side bar
  2. Click on sample details for any one of the sample.
  3. Click on ICMR Specimen Referral Form
  4. See error

Expected behavior
The route should be handled if it is still in use otherwise it need to be handled accordingly. If this is not actively used and gets revamped with new upcoming Lab management module I think we can ignore this.

Additional context

Sentry Issue: CARE-F9X

http://careapi.ohc.network/api/v1/patient/c31e9b1f-0edc-4b4e-9b26-4ad9dfcbd698/test_sample/d5fbfd97-b225-48ef-aff6-914f73b75566/icmr_sample/

TypeError: 'RelatedManager' object is not iterable
(12 additional frame(s) were not displayed)
...
  File "care/facility/api/viewsets/patient_sample.py", line 107, in icmr_sample
    return Response(data=PatientICMRSerializer(patient).data)
  File "care/facility/models/patient_icmr.py", line 164, in symptoms
    for symptom in self.consultation.symptoms:
@JohnLu2004
Copy link
Contributor

Hi @yash-learner,
May I take on this issue?

@yash-learner
Copy link
Member Author

@JohnLu2004 Sorry for inconvenience

As we discussed on Slack this route will be going away soon and with no active users using it. I believe it's not worth fixing it, will close the issue. Please pick a new one.

@yash-learner yash-learner closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants