Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new make target to remove volumes along with the docker containers #2657

Closed
sainak opened this issue Dec 16, 2024 · 3 comments · Fixed by #2658
Closed

Create a new make target to remove volumes along with the docker containers #2657

sainak opened this issue Dec 16, 2024 · 3 comments · Fixed by #2658
Assignees
@saltykheera

Comments

@sainak
Copy link
Member

sainak commented Dec 16, 2024 •
edited
Loading

care/Makefile

Lines 28 to 30 in 7d3d958

down:
docker compose -f docker-compose.yaml -f $(docker_config_file) down

Add a new make target named teardown that runs the above command with the -v flag, this should remove the volumes along with the containers

Add docs for this behavior
@saltykheera
Copy link
Contributor

vishal kumar

@areebahmeddd
Copy link
Contributor

@saltykheera Hey, this seems like a quick fix? Are you still on it?

@saltykheera
Copy link
Contributor

saltykheera commented Dec 16, 2024 •
edited
Loading

yes fixed it making the pr tomorrow positively

@saltykheera saltykheera mentioned this issue Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saltykheera saltykheera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new make target to remove docker volumes along with containers saltykheera/care
3 participants
@sainak @areebahmeddd @saltykheera