Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid archive files #72

Open
cvpeck opened this issue Jan 19, 2022 · 13 comments
Open

Invalid archive files #72

cvpeck opened this issue Jan 19, 2022 · 13 comments

Comments

@cvpeck
Copy link

cvpeck commented Jan 19, 2022

Hi when downloading from component search engine (e.g. a 741 amp ) I receive the following errors -

[INFO] Started watching "/Users/peckc/Downloads"
[INFO] Active formats:
[INFO] 	zip => "/Users/peckc/Documents/KiCadLibraries/ComponentSearchEngine"
[INFO] Detected "/Users/peckc/Downloads/LIB_UA741CDRG4.zip.download/LIB_UA741CDRG4.zip"
[ERROR] Zip(InvalidArchive("Could not find central directory end"))
[INFO] Detected "/Users/peckc/Downloads/LIB_UA741CDRG4.zip.download/LIB_UA741CDRG4.zip"
[ERROR] Io(Os { code: 2, kind: NotFound, message: "No such file or directory" })
[INFO] Detected "/Users/peckc/Downloads/LIB_UA741CDRG4.zip.download/LIB_UA741CDRG4.zip"
[ERROR] Io(Os { code: 2, kind: NotFound, message: "No such file or directory" })

Running macosMonteray 12.1 x86_64

[Edited by olback - fixed formatting]

@cvpeck
Copy link
Author

cvpeck commented Jan 19, 2022

This is configured to watch for zip files which I would then like to import to KiCad

@modularev
Copy link

I have the sam issue as cvpeck, it seems that if recursive watching is disabled it can't even detect the .zip.

Also running Running macOS Monteray 12.1 on ARM

@olback
Copy link
Owner

olback commented Feb 9, 2022

The path /Users/peckc/Downloads/LIB_UA741CDRG4.zip.download/LIB_UA741CDRG4.zip seems odd to me. What browser are you using?

LL watches a folder for file creations and waits some time for the file to be written, then proceeds. If the file is renamed before the download finishes, it'll not work.

@cvpeck
Copy link
Author

cvpeck commented Feb 9, 2022 via email

@olback
Copy link
Owner

olback commented Feb 18, 2022

I have implemented a fix but I have no way of testing it as I don't actually have a Mac.

git pull
git checkout safari-fix
./macos-compile.sh

@cvpeck
Copy link
Author

cvpeck commented Feb 18, 2022 via email

@cvpeck
Copy link
Author

cvpeck commented Feb 20, 2022

Ok, using the above build, it seems the zip files aren't detected at all

[INFO] Started watching "/Users/peckc/Downloads" [INFO] Active formats: [INFO] zip => "/Users/peckc/Documents/KiCadLibraries/ComponentSearchEngine"

Is there any detailed logging I can send you?

@cvpeck
Copy link
Author

cvpeck commented Feb 20, 2022

Adding a seperate entry to watch for KiCad files then extracting the zip and adding the *.epw file to the downloads folder also does not produce any output

[INFO] Started watching "/Users/peckc/Downloads"
[INFO] Active formats:
[INFO] 	zip => "/Users/peckc/Documents/KiCadLibraries/ComponentSearchEngine"
[INFO] 	kicad => "/Users/peckc/Documents/KiCadLibraries/ComponentSearchEngine"

@olback
Copy link
Owner

olback commented Feb 20, 2022

Yeah, if you remove the --release flag in the script, there may be more output.

@cvpeck
Copy link
Author

cvpeck commented Feb 21, 2022

No change other than a few warnings on compilation -
Compiling library-loader-gui v0.3.1 (/Users/peckc/Documents/KiCad/library-loader/ll-gui) warning: unused variable:u--> ll-gui/src/main.rs:48:13 | 48 | let u = Ui::new(app, config, config_path.clone()); | ^ help: if this is intentional, prefix it with an underscore:_u| = note:#[warn(unused_variables)]` on by default

warning: variant is never constructed: UpdateAvailable
--> ll-gui/src/ui/event.rs:8:5
|
8 | UpdateAvailable,
| ^^^^^^^^^^^^^^^
|
= note: #[warn(dead_code)] on by default

warning: associated function is never used: check_logged_in
--> ll-gui/src/ui/mod.rs:274:12
|
274 | pub fn check_logged_in(&self) {
| ^^^^^^^^^^^^^^^

warning: associated function is never used: check_updates
--> ll-gui/src/ui/mod.rs:290:12
|
290 | pub fn check_updates(&self) {
| ^^^^^^^^^^^^^

warning: library-loader-gui (bin "library-loader-gui") generated 4 warnings
Finished dev [unoptimized + debuginfo] target(s) in 6.90s`

@olback
Copy link
Owner

olback commented Feb 21, 2022

git reset --hard
git pull
cargo run --bin library-loader-gui 

I added more debug logging, should show way more information now.

@cvpeck
Copy link
Author

cvpeck commented Feb 25, 2022 via email

@olback
Copy link
Owner

olback commented Feb 28, 2022

Hmm. Looks tricky.

There does not seem to be any Create or Rename events with proper file paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants