Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stargen Fake accretion process. #2

Open
gabrielvelasquez opened this issue Jan 2, 2024 · 2 comments
Open

Stargen Fake accretion process. #2

gabrielvelasquez opened this issue Jan 2, 2024 · 2 comments

Comments

@gabrielvelasquez
Copy link

Stargen Fake accretion process.

The other day I was looking at some of the Stargen code. I was looking for the file(s) that refer to the elements that are used in the accretion process, because the outputs never seem to show any gases other than the ones that you might find on a habitable or almost habitable world. Since I've known that Stargen uses only a handful of elements and molecules, I have believed that Stargen planets are made from nothing because of that, but it wasn't until I noticed this bit of code that decides a planet's density from the distance it is from the star, that I finally realized that the accretion model is completely phony. The list of elements should contain all 98 natural elements, plus another 300 or more molecules to a proper accretion simulation, and have outputs that have gone through a proper coalescing and differentiation, so that they have detailed atmospheres for all planets. Even Mercury has an atmosphere, it's made mainly of Sodium gas. So many outputs have a 100% Neon atmosphere, but fall short of talking about the Neon oceans that would exist closer to the poles, only water oceans are bothered with.
https://en.wikipedia.org/wiki/Extraterrestrial_atmosphere
Sorry to sound so critical, but I can help with this if you ever decide you would like to create an accurate accretion model.
I will eventually expand this part of this code for myself, even if no one ever bothers to use it:

/* Now for a few molecular weights (used for RMS velocity calcs): /
/
This table is from Dole's book "Habitable Planets for Man", p. 38 */

#define ATOMIC_HYDROGEN (1.0) /* H /
#define MOL_HYDROGEN (2.0) /
H2 /
#define HELIUM (4.0) /
He /
#define ATOMIC_NITROGEN (14.0) /
N /
#define ATOMIC_OXYGEN (16.0) /
O /
#define METHANE (16.0) /
CH4 /
#define AMMONIA (17.0) /
NH3 /
#define WATER_VAPOR (18.0) /
H2O /
#define NEON (20.2) /
Ne /
#define MOL_NITROGEN (28.0) /
N2 /
#define CARBON_MONOXIDE (28.0) /
CO /
#define NITRIC_OXIDE (30.0) /
NO /
#define MOL_OXYGEN (32.0) /
O2 /
#define HYDROGEN_SULPHIDE (34.1) /
H2S /
#define ARGON (39.9) /
Ar /
#define CARBON_DIOXIDE (44.0) /
CO2 /
#define NITROUS_OXIDE (44.0) /
N2O /
#define NITROGEN_DIOXIDE (46.0) /
NO2 /
#define OZONE (48.0) /
O3 /
#define SULPH_DIOXIDE (64.1) /
SO2 /
#define SULPH_TRIOXIDE (80.1) /
SO3 /
#define KRYPTON (83.8) /
Kr /
#define XENON (131.3) /
Xe */

// Atomic numbers, are used as a gas ID key

#define AN_H 1
#define AN_HE 2
#define AN_C 6
#define AN_N 7
#define AN_O 8
#define AN_F 9
#define AN_NE 10
#define AN_P 15
#define AN_S 16
#define AN_CL 17
#define AN_AR 18
#define AN_FE 26
#define AN_NI 28
#define AN_CU 29
#define AN_BR 35
#define AN_KR 36
#define AN_I 53
#define AN_XE 54
#define AN_HG 80
#define AN_AT 85
#define AN_RN 86
#define AN_FR 87

#define AN_NH3 900
#define AN_H2O 901
#define AN_CO2 902
#define AN_O3 903
#define AN_CH4 904
#define AN_SO2 905
#define AN_CH3CH2OH 906
#define AN_CO 907

@PlutonianEmpire
Copy link

This branch isn't being worked on anymore, but there are forks of it, including mine

@sirus20x6
Copy link

I would be interested. check out my version here https://github.com/sirus20x6/stargen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants