Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add .only #194

Closed
2 tasks done
botchi09 opened this issue Feb 27, 2024 · 4 comments · Fixed by #196
Closed
2 tasks done

🚀 Feature: Add .only #194

botchi09 opened this issue Feb 27, 2024 · 4 comments · Fixed by #196
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request

Comments

@botchi09
Copy link

botchi09 commented Feb 27, 2024 •
edited by JoshuaKGoldberg
Loading

Feature Request Checklist

Overview

We have emoji.strip, why not a function that does the exact opposite and returns only emojis?

Additional Info

No response
@botchi09 botchi09 added the type: feature New enhancement or request label Feb 27, 2024
@JoshuaKGoldberg

This comment was marked as resolved.

Sign in to view
@JoshuaKGoldberg

This comment was marked as outdated.

Sign in to view
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 5, 2024
Open
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added the status: in discussion Not yet ready for implementation or a pull request label Mar 5, 2024
@JoshuaKGoldberg
Copy link
Collaborator

I'm curious @botchi09: what do you want to use this new function for? Can you provide some more justification as to why it should exist?

@JoshuaKGoldberg JoshuaKGoldberg changed the title Add .only 🚀 Feature: Add .only Mar 5, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 5, 2024
Merged
3 tasks
@botchi09
Copy link
Author

botchi09 commented Mar 6, 2024

I'm curious @botchi09: what do you want to use this new function for? Can you provide some more justification as to why it should exist?

We already have strip, it seems logical to have the opposite. My use case is exactly that, removing every non-emoji from a string. I suppose the alternative is iterating every character and calling .which on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix feature template checklist to be for features, not bugs JoshuaKGoldberg/node-emoji
2 participants
@botchi09 @JoshuaKGoldberg