Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @sindresorhus/is to latest #205

Open
ikelax opened this issue Oct 8, 2024 · 1 comment
Open

Bump @sindresorhus/is to latest #205

ikelax opened this issue Oct 8, 2024 · 1 comment
Labels
status: needs investigation Further research required...?

Comments

@ikelax
Copy link
Contributor

ikelax commented Oct 8, 2024

Currently, we have to use the .default before every property of is, because we're on an older version of @sindresorhus/is that doesn't set up ESM defaults properly yet. An example for this can be found in src/search.ts.

By bumping @sindresorhus/is to latest, we could avoid this.

See also: @JoshuaKGoldberg in #204 (comment)

@JoshuaKGoldberg
Copy link
Collaborator

Agreed, that'd be great. The one tricky thing would be making sure it doesn't change Node.js support for node-emoji itself:

  • Minimum Node.js version: not raising it
  • CJS/ESM: not-old versions of @sindresorthus/* packages don't support CJS natively

...so if either of this being broken is a prerequisite for a version of @sindresorhus/is that fixes the .default shenanigan, then this'd be a breaking change for the next major version.

@JoshuaKGoldberg JoshuaKGoldberg added the status: needs investigation Further research required...? label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs investigation Further research required...?
Projects
None yet
Development

No branches or pull requests

2 participants