Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Pusher Engine #6765

Open
tim-barry opened this issue Nov 26, 2024 · 0 comments
Open

Refactor Pusher Engine #6765

tim-barry opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels
Protocol Team: Issues assigned to the Protocol Pillar. Tech Debt

Comments

@tim-barry
Copy link
Contributor

Problem Definition

The Pusher Engine should be updated to clarify its interface, including blocking versus non-blocking calls, error handling and propagation, documentation, and that it does not process messages from the network (only from the node). See comments on #6747 for more details.

Proposed Solution

  • Replace use of the deprecated engine.Unit with ComponentManager
  • Converting the pusher engine from implementing the network.Engine interface to instead using the network.MessageProcessor interface, but not actually accepting any messages from the network because the pusher.Engine is fed only from internal components
    • use a type-specific function/interface for interaction from the Finalizer
  • Ensure unit tests accurately reflect the necessary functionality of the pusher engine
@tim-barry tim-barry self-assigned this Nov 26, 2024
@tim-barry tim-barry added Protocol Team: Issues assigned to the Protocol Pillar. and removed S-Protocol labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Protocol Team: Issues assigned to the Protocol Pillar. Tech Debt
Projects
None yet
Development

No branches or pull requests

1 participant