New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flow EVM] Consider including `RevertReason` string in `EVM.TransactionExecuted` event payload #6770

Open

m-Peter opened this issue Nov 29, 2024 · 0 comments · May be fixed by #6836

Assignees

Labels

Flow EVM Improvement

Collaborator

m-Peter commented Nov 29, 2024

Instead of having a plain execution reverted error message, as in here: https://www.flowscan.io/tx/77e8b04758bbf599c126633a58c6ff77f628b31db0af242c097f53c58e235d20/events, we could also parse the RevertReason, whenever applicable, and make it part of the event payload, can be seen here: https://evm.flowscan.io/tx/0x7914bb5b13bac6f621bc37bbf6e406fbf4472aaaaf17ec2f309a92aca4e27fc0. The EVM Gateway already does the parsing, with this condition: https://github.com/onflow/flow-evm-gateway/blob/main/services/requester/requester.go#L840-L842.

The text was updated successfully, but these errors were encountered:

m-Peter added Flow EVM Improvement labels

j1010001 assigned m-Peter

m-Peter linked a pull request

that will close this issue

Include human-friendly error messages on EVM transaction events #6836

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment