Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image saving more robust in TexturedPhotogrammetryMesh.save_renders_pytorch3d #72

Open
russelldj opened this issue Jan 29, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@russelldj
Copy link
Collaborator

Right now, the save_renders_pytorch3d function isn't particularly robust or flexible. Specifically, on this line, it casts the data to np.uint8. This may not be suitable for some applications, such as rendering a height map.

With float data, you wouldn't be able to do the compositing that we currently do, since it assumes the data can be visualized as a three-channel uint8. So handling this case would require some additional thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant