Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement 'no interest' state to /explore Recommendation Section #4149

Closed
wants to merge 6 commits into from
Closed

feat: implement 'no interest' state to /explore Recommendation Section #4149

wants to merge 6 commits into from

Conversation

zeucapua
Copy link
Contributor

@zeucapua zeucapua commented Sep 30, 2024 •
edited
Loading

Description

If a user has no interests set, they will not get recommendations. The /explore "Recommended For You" section will instead show the list of interests for the user to pick from. On update/refresh, the page should start showing recommendations.

Related Tickets & Documents

Closes #4124

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

larry-david-curb-your-enthusiasm-gif

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 1de38c7
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66febc5b4de777000867084a
😎 Deploy Preview https://deploy-preview-4149--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 1de38c7
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66febc5bf9034d0008373722
😎 Deploy Preview https://deploy-preview-4149--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeucapua zeucapua marked this pull request as ready for review October 1, 2024 16:58
@zeucapua zeucapua requested a review from a team October 1, 2024 16:59
jpmcb
jpmcb reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I log in, I get the "Connect with GitHub" view:

Screenshot 2024-10-01 at 11 36 45 AM

and then a few seconds latter, it flips to the recommended view: can we have a loading state instead?

@nickytonline
Copy link
Member

I get the login screen as well, but also no workspaces are loaded or trending repos.

CleanShot 2024-10-01 at 13 14 35@2x

Discover Workspaces seems off as well. The heading is all scrunched on larger screens whereas the other headings are not when the windows is fully maximized on my 14" MBP.

CleanShot 2024-10-01 at 13 17 19

@zeucapua
Copy link
Contributor Author

zeucapua commented Oct 1, 2024

After I log in, I get the "Connect with GitHub" view:

Screenshot 2024-10-01 at 11 36 45 AM

and then a few seconds latter, it flips to the recommended view: can we have a loading state instead?

There should be a loading state, but it's weird it's not showing up. I assume it's cause the useSession hook takes a minute so it thinks that a user isn't logged in. Let me change things around to fix.

@zeucapua
Copy link
Contributor Author

zeucapua commented Oct 1, 2024 •
edited
Loading

I get the login screen as well, but also no workspaces are loaded or trending repos.

CleanShot 2024-10-01 at 13 14 35@2x

Discover Workspaces seems off as well. The heading is all scrunched on larger screens whereas the other headings are not when the windows is fully maximized on my 14" MBP.

CleanShot 2024-10-01 at 13 17 19

Your comment seems to be inline with the DNS errors when migrating the beta API on the backend. Trending should be loading, and the Discover Workspaces section will error since they are hardcoded for production workspaces. There's an issue to change it based on the environment here: #4107

@zeucapua zeucapua requested a review from jpmcb October 4, 2024 16:08
jpmcb
jpmcb reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@jpmcb jpmcb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still briefly see the "Login" button and chunk.

And then it never loads actual recommendations:

Screenshot 2024-10-04 at 12 09 59 PM

Also notice that the workspaces aren't loading.

Hitting hard refresh a few times seems to have corrected the issue ... maybe I was getting a cached version of the page?

@nickytonline
Copy link
Member

nickytonline commented Oct 6, 2024 •
edited
Loading

I'm still getting errors for trending repositories, and like @jpmcb, no workspaces are loading. I'm guessing workspaces aren't loading because they are production workspace IDs. We don't have an administration page for stuff like this, so consider adding FEATURED_WORKSPACES as an environment variable for now. I can show you how to set this up in Netlify so we have beta and prod worskpace IDs.

app/pages/explore/index.tsx

Lines 23 to 30 in 1de38c7

export const FEATURED_WORKSPACES = [
"b355ecef-76a5-4451-972a-281e16ccf2e4", // Brandon's "Angular"
"0950814d-ed16-4201-add8-d17479cfdc1f", // Zeu's "OSS Companies"
"190972f6-caa8-4a90-a21d-2322259b90c7", // Bekah's "CNCF Top 30"
"4835f232-ec69-474d-9b88-b2b779015e08", // John's "Go Hotness"
"7b540a5d-a767-4f8f-8295-2eccf31ca568", // Brian's "Vite Ecosystem"
"380d1129-cd99-4958-83c7-f5d8c4f778af", // Nick's "Daishi's Greatest Hits"
];

CleanShot 2024-10-06 at 10 45 36

Also, if I'm logged out, I get a hydration error.

CleanShot 2024-10-06 at 10 46 01

@BekahHW
Copy link
Member

BekahHW commented Oct 7, 2024

Can we change the copy to be more general for maintainer or contributor? Also, bc it takes the user to the repo page as well:

Current
Here are some repositories we think would be great for you. Click on one to start contributing!

Suggestion

Discover repositories tailored to your interests. Click any to learn more!

Additional Change
Below the "Recommended for You" heading, remove the copy (Here are some repositories we think would be great for you. Click on one to start contributing!) if there are no projects displayed.

@zeucapua
Copy link
Contributor Author

Closed - not priority, will not merge anytime soon.

@zeucapua zeucapua closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcb jpmcb jpmcb left review comments

@brandonroberts brandonroberts Awaiting requested review from brandonroberts brandonroberts is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add State for No Interests Selected on the Explore page
4 participants
@zeucapua @nickytonline @BekahHW @jpmcb