diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md index f68e4c49d4..a8a31d480a 100644 --- a/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md @@ -30,11 +30,13 @@ for the same information. Note that `server.address` is only included when the `EnableConnectionLevelAttributes` option is enabled. ([#2229](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2229)) -* When `EnableConnectionLevelAttributes` is enabled, the `server.port` attribute - will now be written as an integer to be compliant with the - [semantic conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/server.md). +* **Breaking change**: When `EnableConnectionLevelAttributes` is enabled, the + `server.port` attribute will now be written as an integer to be compliant with + the [semantic conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/server.md). Previously, it was written as a string. ([#2233](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2233)) +* The `EnableConnectionLevelAttributes` option is now enabled by default. + ([#TBD](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/TBD)) ## 1.9.0-beta.1 diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/README.md b/src/OpenTelemetry.Instrumentation.SqlClient/README.md index f5fe916ac3..19837d53bc 100644 --- a/src/OpenTelemetry.Instrumentation.SqlClient/README.md +++ b/src/OpenTelemetry.Instrumentation.SqlClient/README.md @@ -165,8 +165,8 @@ command text will be captured. > [!NOTE] > EnableConnectionLevelAttributes is supported on all runtimes. -By default, `EnabledConnectionLevelAttributes` is disabled. -If `EnabledConnectionLevelAttributes` is enabled, +By default, `EnabledConnectionLevelAttributes` is enabled. +When `EnabledConnectionLevelAttributes` is enabled, the [`DataSource`](https://docs.microsoft.com/dotnet/api/system.data.common.dbconnection.datasource) will be parsed and the server name or IP address will be sent as the `server.address` attribute, the instance name will be sent as