Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geneva] Add missing XML docs for public APIs #2044

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

CodeBlanch
Copy link
Member

Changes

  • Enable CS1591 in GenevaExporter and add missing XML docs for public APIs.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team September 7, 2024 05:49
@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva labels Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (71655ce) to head (9d5deb9).
Report is 405 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
- Coverage   73.91%   72.51%   -1.40%     
==========================================
  Files         267      315      +48     
  Lines        9615    12216    +2601     
==========================================
+ Hits         7107     8859    +1752     
- Misses       2508     3357     +849     
Flag Coverage Δ
unittests-Exporter.Geneva 53.20% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 71.24% <ø> (?)
unittests-Exporter.OneCollector 94.31% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 88.57% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 75.77% <ø> (?)
unittests-Instrumentation.AWSLambda 88.92% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 82.06% <ø> (?)
unittests-Instrumentation.Owin 85.79% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 67.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 77.93% <ø> (?)
unittests-Resources.Azure 82.35% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 73.94% <ø> (?)
unittests-Resources.OperatingSystem 80.00% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 77.08% <ø> (?)
unittests-Sampler.AWS 87.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
....Exporter.Geneva/GenevaExporterHelperExtensions.cs 98.18% <ø> (+30.00%) ⬆️
...Telemetry.Exporter.Geneva/GenevaExporterOptions.cs 90.24% <ø> (+0.24%) ⬆️
...OpenTelemetry.Exporter.Geneva/GenevaLogExporter.cs 57.50% <ø> (-20.00%) ⬇️
...lemetry.Exporter.Geneva/GenevaLoggingExtensions.cs 95.08% <ø> (+9.36%) ⬆️
...enTelemetry.Exporter.Geneva/GenevaTraceExporter.cs 52.50% <ø> (-22.50%) ⬇️
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 76.47% <ø> (+9.80%) ⬆️
...r.Geneva/Metrics/GenevaMetricExporterExtensions.cs 93.33% <ø> (ø)
...rter.Geneva/Metrics/GenevaMetricExporterOptions.cs 100.00% <ø> (ø)

... and 337 files with indirect coverage changes

@cijothomas cijothomas merged commit ddd0a2e into open-telemetry:main Sep 7, 2024
212 of 213 checks passed
@CodeBlanch CodeBlanch deleted the genevaexporter-xml-docs branch September 9, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants