Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ActivityExtensions.SetStatus by Activity.SetStatus(.WithDescription) #2321

Closed
Kielek opened this issue Nov 13, 2024 · 0 comments · Fixed by #2358
Closed

Replace ActivityExtensions.SetStatus by Activity.SetStatus(.WithDescription) #2321

Kielek opened this issue Nov 13, 2024 · 0 comments · Fixed by #2358

Comments

@Kielek
Copy link
Contributor

Kielek commented Nov 13, 2024

Where something was calling ActivityExtensions.SetStatus I suppressed warning instead of updating to use Activity.Status \ Activity.StatusDescription. The reason for that is they don't do the same things. In order for Activity.Status \ Activity.StatusDescription to work, users need to also upgrade to a compatible exporter which understands the status fields on Activity. I decided calling the old extension for now was the safer bet.

Originally posted by @CodeBlanch in #2317 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace ActivityExtensions.SetStatus by Activity.SetStatus Kielek/opentelemetry-dotnet-contrib
1 participant
@Kielek