[repo] Metrics instrumentations - utilize advice API for histogram boundaries #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:instrumentation.aspnet
CodeBlanch
reviewed
Dec 18, 2024
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Histograms produced by this instrumentation package specify explicit bucket boundaries. | |||
There was a problem hiding this comment.
I think we could level this up a bit.
- The
http.server.request.durationhistogram (measured in seconds) produced by the metrics instrumentation in this package now uses the Advice API to set default explicit buckets following the OpenTelemetry Specification.
There was a problem hiding this comment.
Fixed, with stable links ffee25f
There was a problem hiding this comment.
I approved but I don't know if I love the stable link part 😄 Fine for the semantic conventions. But the link to advice API doc in main repo, I'm hoping to update that if this ever lands: dotnet/docs#43640
Co-authored-by: Mikel Blanchard <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2430 +/- ##
==========================================
- Coverage 73.91% 0 -73.92%
==========================================
Files 267 0 -267
Lines 9615 0 -9615
==========================================
- Hits 7107 0 -7107
+ Misses 2508 0 -2508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
[repo] Metrics instrumentations - utilize advice API for histogram boundaries
Values taken from semantic conventions.
Kafka also adds units and descriptions.
Merge requirement checklist
[ ] Unit tests added/updatedCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)